qemu/include/hw/audio
Manos Pitsidianakis 731655f87f virtio-snd: rewrite invalid tx/rx message handling
The current handling of invalid virtqueue elements inside the TX/RX virt
queue handlers is wrong.

They are added in a per-stream invalid queue to be processed after the
handler is done examining each message, but the invalid message might
not be specifying any stream_id; which means it's invalid to add it to
any stream->invalid queue since stream could be NULL at this point.

This commit moves the invalid queue to the VirtIOSound struct which
guarantees there will always be a valid temporary place to store them
inside the tx/rx handlers. The queue will be emptied before the handler
returns, so the queue must be empty at any other point of the device's
lifetime.

Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-Id: <virtio-snd-rewrite-invalid-tx-rx-message-handling-v1.manos.pitsidianakis@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2024-04-09 02:31:16 -04:00
..
asc.h m68k: Clean up includes 2024-01-30 21:20:20 +03:00
pcspk.h hw/audio/pcspk: Inline pcspk_init() 2023-10-19 23:13:28 +02:00
soundhw.h hw/audio/soundhw: Clean up global variable shadowing 2023-10-06 13:16:57 +02:00
virtio-snd.h virtio-snd: rewrite invalid tx/rx message handling 2024-04-09 02:31:16 -04:00
wm8750.h Include hw/hw.h exactly where needed 2019-08-16 13:31:52 +02:00