mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-11-05 20:35:44 +00:00
e3f9fe2d40
There are lots of duplicate parsing code using strto*() in QEMU, and
most of that code is broken in one way or another. Even the visitors
code have duplicate integer parsing code[1]. This introduces functions
to help parsing unsigned int values: parse_uint() and parse_uint_full().
Parsing functions for signed ints and floats will be submitted later.
parse_uint_full() has all the checks made by opts_type_uint64() at
opts-visitor.c:
- Check for NULL (returns -EINVAL)
- Check for negative numbers (returns -EINVAL)
- Check for empty string (returns -EINVAL)
- Check for overflow or other errno values set by strtoll() (returns
-errno)
- Check for end of string (reject invalid characters after number)
(returns -EINVAL)
parse_uint() does everything above except checking for the end of the
string, so callers can continue parsing the remainder of string after
the number.
Unit tests included.
[1] string-input-visitor.c:parse_int() could use the same parsing code
used by opts-visitor.c:opts_type_int(), instead of duplicating that
logic.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
251 lines
6.3 KiB
C
251 lines
6.3 KiB
C
/*
|
|
* cutils.c unit-tests
|
|
*
|
|
* Copyright (C) 2013 Red Hat Inc.
|
|
*
|
|
* Authors:
|
|
* Eduardo Habkost <ehabkost@redhat.com>
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include <glib.h>
|
|
#include <errno.h>
|
|
#include <string.h>
|
|
|
|
#include "qemu-common.h"
|
|
|
|
|
|
static void test_parse_uint_null(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
char f = 'X';
|
|
char *endptr = &f;
|
|
int r;
|
|
|
|
r = parse_uint(NULL, &i, &endptr, 0);
|
|
|
|
g_assert_cmpint(r, ==, -EINVAL);
|
|
g_assert_cmpint(i, ==, 0);
|
|
g_assert(endptr == NULL);
|
|
}
|
|
|
|
static void test_parse_uint_empty(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
char f = 'X';
|
|
char *endptr = &f;
|
|
const char *str = "";
|
|
int r;
|
|
|
|
r = parse_uint(str, &i, &endptr, 0);
|
|
|
|
g_assert_cmpint(r, ==, -EINVAL);
|
|
g_assert_cmpint(i, ==, 0);
|
|
g_assert(endptr == str);
|
|
}
|
|
|
|
static void test_parse_uint_whitespace(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
char f = 'X';
|
|
char *endptr = &f;
|
|
const char *str = " \t ";
|
|
int r;
|
|
|
|
r = parse_uint(str, &i, &endptr, 0);
|
|
|
|
g_assert_cmpint(r, ==, -EINVAL);
|
|
g_assert_cmpint(i, ==, 0);
|
|
g_assert(endptr == str);
|
|
}
|
|
|
|
|
|
static void test_parse_uint_invalid(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
char f = 'X';
|
|
char *endptr = &f;
|
|
const char *str = " \t xxx";
|
|
int r;
|
|
|
|
r = parse_uint(str, &i, &endptr, 0);
|
|
|
|
g_assert_cmpint(r, ==, -EINVAL);
|
|
g_assert_cmpint(i, ==, 0);
|
|
g_assert(endptr == str);
|
|
}
|
|
|
|
|
|
static void test_parse_uint_trailing(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
char f = 'X';
|
|
char *endptr = &f;
|
|
const char *str = "123xxx";
|
|
int r;
|
|
|
|
r = parse_uint(str, &i, &endptr, 0);
|
|
|
|
g_assert_cmpint(r, ==, 0);
|
|
g_assert_cmpint(i, ==, 123);
|
|
g_assert(endptr == str + 3);
|
|
}
|
|
|
|
static void test_parse_uint_correct(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
char f = 'X';
|
|
char *endptr = &f;
|
|
const char *str = "123";
|
|
int r;
|
|
|
|
r = parse_uint(str, &i, &endptr, 0);
|
|
|
|
g_assert_cmpint(r, ==, 0);
|
|
g_assert_cmpint(i, ==, 123);
|
|
g_assert(endptr == str + strlen(str));
|
|
}
|
|
|
|
static void test_parse_uint_octal(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
char f = 'X';
|
|
char *endptr = &f;
|
|
const char *str = "0123";
|
|
int r;
|
|
|
|
r = parse_uint(str, &i, &endptr, 0);
|
|
|
|
g_assert_cmpint(r, ==, 0);
|
|
g_assert_cmpint(i, ==, 0123);
|
|
g_assert(endptr == str + strlen(str));
|
|
}
|
|
|
|
static void test_parse_uint_decimal(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
char f = 'X';
|
|
char *endptr = &f;
|
|
const char *str = "0123";
|
|
int r;
|
|
|
|
r = parse_uint(str, &i, &endptr, 10);
|
|
|
|
g_assert_cmpint(r, ==, 0);
|
|
g_assert_cmpint(i, ==, 123);
|
|
g_assert(endptr == str + strlen(str));
|
|
}
|
|
|
|
|
|
static void test_parse_uint_llong_max(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
char f = 'X';
|
|
char *endptr = &f;
|
|
char *str = g_strdup_printf("%llu", (unsigned long long)LLONG_MAX + 1);
|
|
int r;
|
|
|
|
r = parse_uint(str, &i, &endptr, 0);
|
|
|
|
g_assert_cmpint(r, ==, 0);
|
|
g_assert_cmpint(i, ==, (unsigned long long)LLONG_MAX + 1);
|
|
g_assert(endptr == str + strlen(str));
|
|
|
|
g_free(str);
|
|
}
|
|
|
|
static void test_parse_uint_overflow(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
char f = 'X';
|
|
char *endptr = &f;
|
|
const char *str = "99999999999999999999999999999999999999";
|
|
int r;
|
|
|
|
r = parse_uint(str, &i, &endptr, 0);
|
|
|
|
g_assert_cmpint(r, ==, -ERANGE);
|
|
g_assert_cmpint(i, ==, ULLONG_MAX);
|
|
g_assert(endptr == str + strlen(str));
|
|
}
|
|
|
|
static void test_parse_uint_negative(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
char f = 'X';
|
|
char *endptr = &f;
|
|
const char *str = " \t -321";
|
|
int r;
|
|
|
|
r = parse_uint(str, &i, &endptr, 0);
|
|
|
|
g_assert_cmpint(r, ==, -ERANGE);
|
|
g_assert_cmpint(i, ==, 0);
|
|
g_assert(endptr == str + strlen(str));
|
|
}
|
|
|
|
|
|
static void test_parse_uint_full_trailing(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
const char *str = "123xxx";
|
|
int r;
|
|
|
|
r = parse_uint_full(str, &i, 0);
|
|
|
|
g_assert_cmpint(r, ==, -EINVAL);
|
|
g_assert_cmpint(i, ==, 0);
|
|
}
|
|
|
|
static void test_parse_uint_full_correct(void)
|
|
{
|
|
unsigned long long i = 999;
|
|
const char *str = "123";
|
|
int r;
|
|
|
|
r = parse_uint_full(str, &i, 0);
|
|
|
|
g_assert_cmpint(r, ==, 0);
|
|
g_assert_cmpint(i, ==, 123);
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
g_test_init(&argc, &argv, NULL);
|
|
|
|
g_test_add_func("/cutils/parse_uint/null", test_parse_uint_null);
|
|
g_test_add_func("/cutils/parse_uint/empty", test_parse_uint_empty);
|
|
g_test_add_func("/cutils/parse_uint/whitespace",
|
|
test_parse_uint_whitespace);
|
|
g_test_add_func("/cutils/parse_uint/invalid", test_parse_uint_invalid);
|
|
g_test_add_func("/cutils/parse_uint/trailing", test_parse_uint_trailing);
|
|
g_test_add_func("/cutils/parse_uint/correct", test_parse_uint_correct);
|
|
g_test_add_func("/cutils/parse_uint/octal", test_parse_uint_octal);
|
|
g_test_add_func("/cutils/parse_uint/decimal", test_parse_uint_decimal);
|
|
g_test_add_func("/cutils/parse_uint/llong_max", test_parse_uint_llong_max);
|
|
g_test_add_func("/cutils/parse_uint/overflow", test_parse_uint_overflow);
|
|
g_test_add_func("/cutils/parse_uint/negative", test_parse_uint_negative);
|
|
g_test_add_func("/cutils/parse_uint_full/trailing",
|
|
test_parse_uint_full_trailing);
|
|
g_test_add_func("/cutils/parse_uint_full/correct",
|
|
test_parse_uint_full_correct);
|
|
|
|
return g_test_run();
|
|
}
|