mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 18:05:37 +00:00
![Alex Bennée](/assets/img/avatar_default.png)
Investigating why some BMC models are so slow compared to a plain ARM virt machines I did some profiling of: ./qemu-system-arm -M romulus-bmc -nic user \ -drive file=obmc-phosphor-image-romulus.static.mtd,format=raw,if=mtd \ -nographic -serial mon:stdio And saw that object_class_dynamic_cast_assert was dominating the profile times. We have a number of cases in this model of the SSI bus. As the class is static once the object is created we just cache it and use it instead of the dynamic case macros. Profiling against: ./tests/venv/bin/avocado run \ tests/avocado/machine_aspeed.py:test_arm_ast2500_romulus_openbmc_v2_9_0 Before: 35.565 s ± 0.087 s After: 15.713 s ± 0.287 s Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Cc: Cédric Le Goater <clg@kaod.org> Tested-by: Cédric Le Goater <clg@kaod.org> Reviewed-by: Cédric Le Goater <clg@kaod.org> Message-Id: <20220811151413.3350684-6-alex.bennee@linaro.org> Message-Id: <20220923084803.498337-6-clg@kaod.org> Signed-off-by: Cédric Le Goater <clg@kaod.org>
145 lines
3.5 KiB
C
145 lines
3.5 KiB
C
/*
|
|
* QEMU Synchronous Serial Interface support
|
|
*
|
|
* Copyright (c) 2009 CodeSourcery.
|
|
* Copyright (c) 2012 Peter A.G. Crosthwaite (peter.crosthwaite@petalogix.com)
|
|
* Copyright (c) 2012 PetaLogix Pty Ltd.
|
|
* Written by Paul Brook
|
|
*
|
|
* This code is licensed under the GNU GPL v2.
|
|
*
|
|
* Contributions after 2012-01-13 are licensed under the terms of the
|
|
* GNU GPL, version 2 or (at your option) any later version.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "hw/ssi/ssi.h"
|
|
#include "migration/vmstate.h"
|
|
#include "qemu/module.h"
|
|
#include "qapi/error.h"
|
|
#include "qom/object.h"
|
|
|
|
struct SSIBus {
|
|
BusState parent_obj;
|
|
};
|
|
|
|
#define TYPE_SSI_BUS "SSI"
|
|
OBJECT_DECLARE_SIMPLE_TYPE(SSIBus, SSI_BUS)
|
|
|
|
static const TypeInfo ssi_bus_info = {
|
|
.name = TYPE_SSI_BUS,
|
|
.parent = TYPE_BUS,
|
|
.instance_size = sizeof(SSIBus),
|
|
};
|
|
|
|
static void ssi_cs_default(void *opaque, int n, int level)
|
|
{
|
|
SSIPeripheral *s = SSI_PERIPHERAL(opaque);
|
|
bool cs = !!level;
|
|
assert(n == 0);
|
|
if (s->cs != cs) {
|
|
if (s->spc->set_cs) {
|
|
s->spc->set_cs(s, cs);
|
|
}
|
|
}
|
|
s->cs = cs;
|
|
}
|
|
|
|
static uint32_t ssi_transfer_raw_default(SSIPeripheral *dev, uint32_t val)
|
|
{
|
|
SSIPeripheralClass *ssc = dev->spc;
|
|
|
|
if ((dev->cs && ssc->cs_polarity == SSI_CS_HIGH) ||
|
|
(!dev->cs && ssc->cs_polarity == SSI_CS_LOW) ||
|
|
ssc->cs_polarity == SSI_CS_NONE) {
|
|
return ssc->transfer(dev, val);
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static void ssi_peripheral_realize(DeviceState *dev, Error **errp)
|
|
{
|
|
SSIPeripheral *s = SSI_PERIPHERAL(dev);
|
|
SSIPeripheralClass *ssc = SSI_PERIPHERAL_GET_CLASS(s);
|
|
|
|
if (ssc->transfer_raw == ssi_transfer_raw_default &&
|
|
ssc->cs_polarity != SSI_CS_NONE) {
|
|
qdev_init_gpio_in_named(dev, ssi_cs_default, SSI_GPIO_CS, 1);
|
|
}
|
|
s->spc = ssc;
|
|
|
|
ssc->realize(s, errp);
|
|
}
|
|
|
|
static void ssi_peripheral_class_init(ObjectClass *klass, void *data)
|
|
{
|
|
SSIPeripheralClass *ssc = SSI_PERIPHERAL_CLASS(klass);
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
|
|
dc->realize = ssi_peripheral_realize;
|
|
dc->bus_type = TYPE_SSI_BUS;
|
|
if (!ssc->transfer_raw) {
|
|
ssc->transfer_raw = ssi_transfer_raw_default;
|
|
}
|
|
}
|
|
|
|
static const TypeInfo ssi_peripheral_info = {
|
|
.name = TYPE_SSI_PERIPHERAL,
|
|
.parent = TYPE_DEVICE,
|
|
.class_init = ssi_peripheral_class_init,
|
|
.class_size = sizeof(SSIPeripheralClass),
|
|
.abstract = true,
|
|
};
|
|
|
|
bool ssi_realize_and_unref(DeviceState *dev, SSIBus *bus, Error **errp)
|
|
{
|
|
return qdev_realize_and_unref(dev, &bus->parent_obj, errp);
|
|
}
|
|
|
|
DeviceState *ssi_create_peripheral(SSIBus *bus, const char *name)
|
|
{
|
|
DeviceState *dev = qdev_new(name);
|
|
|
|
ssi_realize_and_unref(dev, bus, &error_fatal);
|
|
return dev;
|
|
}
|
|
|
|
SSIBus *ssi_create_bus(DeviceState *parent, const char *name)
|
|
{
|
|
BusState *bus;
|
|
bus = qbus_new(TYPE_SSI_BUS, parent, name);
|
|
return SSI_BUS(bus);
|
|
}
|
|
|
|
uint32_t ssi_transfer(SSIBus *bus, uint32_t val)
|
|
{
|
|
BusState *b = BUS(bus);
|
|
BusChild *kid;
|
|
uint32_t r = 0;
|
|
|
|
QTAILQ_FOREACH(kid, &b->children, sibling) {
|
|
SSIPeripheral *p = SSI_PERIPHERAL(kid->child);
|
|
r |= p->spc->transfer_raw(p, val);
|
|
}
|
|
|
|
return r;
|
|
}
|
|
|
|
const VMStateDescription vmstate_ssi_peripheral = {
|
|
.name = "SSISlave",
|
|
.version_id = 1,
|
|
.minimum_version_id = 1,
|
|
.fields = (VMStateField[]) {
|
|
VMSTATE_BOOL(cs, SSIPeripheral),
|
|
VMSTATE_END_OF_LIST()
|
|
}
|
|
};
|
|
|
|
static void ssi_peripheral_register_types(void)
|
|
{
|
|
type_register_static(&ssi_bus_info);
|
|
type_register_static(&ssi_peripheral_info);
|
|
}
|
|
|
|
type_init(ssi_peripheral_register_types)
|