mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 18:05:37 +00:00
![Stefan Hajnoczi](/assets/img/avatar_default.png)
We're supposed to keep qerror definitions and table entries in alphabetical order. In practice this is not checked. I haven't found a nice way to integrate this into the makefile yet but we can at least have this script which verifies that qerrors are in alphabetical order. Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
23 lines
635 B
Bash
Executable file
23 lines
635 B
Bash
Executable file
#!/bin/sh
|
|
# This script verifies that qerror definitions and table entries are
|
|
# alphabetically ordered.
|
|
|
|
check_order() {
|
|
errmsg=$1
|
|
shift
|
|
|
|
# sort -C verifies order but does not print a message. sort -c does print a
|
|
# message. These options are both in POSIX.
|
|
if ! "$@" | sort -C; then
|
|
echo "$errmsg"
|
|
"$@" | sort -c
|
|
exit 1
|
|
fi
|
|
return 0
|
|
}
|
|
|
|
check_order 'Definitions in qerror.h must be in alphabetical order:' \
|
|
grep '^#define QERR_' qerror.h
|
|
check_order 'Entries in qerror.c:qerror_table must be in alphabetical order:' \
|
|
sed -n '/^static.*qerror_table\[\]/,/^};/s/QERR_/&/gp' qerror.c
|