mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 18:05:37 +00:00
![Ding Hui](/assets/img/avatar_default.png)
When we connect to vnc by websocket channel, and disconnect (maybe by some network exception) before handshake, qemu will left CLOSE_WAIT socket and never close it After04d2529da2
("ui: convert VNC server to use QIOChannelSocket") anddd154c4d9f
("io: fix handling of EOF / error conditions in websock GSource"), the vnc call qio_channel_add_watch only care about G_IO_IN, but mising G_IO_HUP and G_IO_ERR. When the websocket channel get EOF or error, it cannot callback, because the caller ignore the event, that leads to resource leak We need handle G_IO_HUP and G_IO_ERR event, then cleanup the channel Fixes:04d2529da2
("ui: convert VNC server to use QIOChannelSocket") Fixes:dd154c4d9f
("io: fix handling of EOF / error conditions in websock GSource") Cc: qemu-stable@nongnu.org Signed-off-by: Ding Hui <dinghui@sangfor.com.cn> Message-id: 20201029032241.11040-1-dinghui@sangfor.com.cn Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
167 lines
5.2 KiB
C
167 lines
5.2 KiB
C
/*
|
|
* QEMU VNC display driver: VeNCrypt authentication setup
|
|
*
|
|
* Copyright (C) 2006 Anthony Liguori <anthony@codemonkey.ws>
|
|
* Copyright (C) 2006 Fabrice Bellard
|
|
* Copyright (C) 2009 Red Hat, Inc
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "vnc.h"
|
|
#include "qapi/error.h"
|
|
#include "qemu/main-loop.h"
|
|
#include "trace.h"
|
|
|
|
static void start_auth_vencrypt_subauth(VncState *vs)
|
|
{
|
|
switch (vs->subauth) {
|
|
case VNC_AUTH_VENCRYPT_TLSNONE:
|
|
case VNC_AUTH_VENCRYPT_X509NONE:
|
|
vnc_write_u32(vs, 0); /* Accept auth completion */
|
|
start_client_init(vs);
|
|
break;
|
|
|
|
case VNC_AUTH_VENCRYPT_TLSVNC:
|
|
case VNC_AUTH_VENCRYPT_X509VNC:
|
|
start_auth_vnc(vs);
|
|
break;
|
|
|
|
#ifdef CONFIG_VNC_SASL
|
|
case VNC_AUTH_VENCRYPT_TLSSASL:
|
|
case VNC_AUTH_VENCRYPT_X509SASL:
|
|
start_auth_sasl(vs);
|
|
break;
|
|
#endif /* CONFIG_VNC_SASL */
|
|
|
|
default: /* Should not be possible, but just in case */
|
|
trace_vnc_auth_fail(vs, vs->auth, "Unhandled VeNCrypt subauth", "");
|
|
vnc_write_u8(vs, 1);
|
|
if (vs->minor >= 8) {
|
|
static const char err[] = "Unsupported authentication type";
|
|
vnc_write_u32(vs, sizeof(err));
|
|
vnc_write(vs, err, sizeof(err));
|
|
}
|
|
vnc_client_error(vs);
|
|
}
|
|
}
|
|
|
|
static void vnc_tls_handshake_done(QIOTask *task,
|
|
gpointer user_data)
|
|
{
|
|
VncState *vs = user_data;
|
|
Error *err = NULL;
|
|
|
|
if (qio_task_propagate_error(task, &err)) {
|
|
trace_vnc_auth_fail(vs, vs->auth, "TLS handshake failed",
|
|
error_get_pretty(err));
|
|
vnc_client_error(vs);
|
|
error_free(err);
|
|
} else {
|
|
if (vs->ioc_tag) {
|
|
g_source_remove(vs->ioc_tag);
|
|
}
|
|
vs->ioc_tag = qio_channel_add_watch(
|
|
vs->ioc, G_IO_IN | G_IO_HUP | G_IO_ERR | G_IO_OUT,
|
|
vnc_client_io, vs, NULL);
|
|
start_auth_vencrypt_subauth(vs);
|
|
}
|
|
}
|
|
|
|
|
|
static int protocol_client_vencrypt_auth(VncState *vs, uint8_t *data, size_t len)
|
|
{
|
|
int auth = read_u32(data, 0);
|
|
|
|
trace_vnc_auth_vencrypt_subauth(vs, auth);
|
|
if (auth != vs->subauth) {
|
|
trace_vnc_auth_fail(vs, vs->auth, "Unsupported sub-auth version", "");
|
|
vnc_write_u8(vs, 0); /* Reject auth */
|
|
vnc_flush(vs);
|
|
vnc_client_error(vs);
|
|
} else {
|
|
Error *err = NULL;
|
|
QIOChannelTLS *tls;
|
|
vnc_write_u8(vs, 1); /* Accept auth */
|
|
vnc_flush(vs);
|
|
|
|
if (vs->ioc_tag) {
|
|
g_source_remove(vs->ioc_tag);
|
|
vs->ioc_tag = 0;
|
|
}
|
|
|
|
tls = qio_channel_tls_new_server(
|
|
vs->ioc,
|
|
vs->vd->tlscreds,
|
|
vs->vd->tlsauthzid,
|
|
&err);
|
|
if (!tls) {
|
|
trace_vnc_auth_fail(vs, vs->auth, "TLS setup failed",
|
|
error_get_pretty(err));
|
|
error_free(err);
|
|
vnc_client_error(vs);
|
|
return 0;
|
|
}
|
|
|
|
qio_channel_set_name(QIO_CHANNEL(tls), "vnc-server-tls");
|
|
object_unref(OBJECT(vs->ioc));
|
|
vs->ioc = QIO_CHANNEL(tls);
|
|
trace_vnc_client_io_wrap(vs, vs->ioc, "tls");
|
|
vs->tls = qio_channel_tls_get_session(tls);
|
|
|
|
qio_channel_tls_handshake(tls,
|
|
vnc_tls_handshake_done,
|
|
vs,
|
|
NULL,
|
|
NULL);
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static int protocol_client_vencrypt_init(VncState *vs, uint8_t *data, size_t len)
|
|
{
|
|
trace_vnc_auth_vencrypt_version(vs, (int)data[0], (int)data[1]);
|
|
if (data[0] != 0 ||
|
|
data[1] != 2) {
|
|
trace_vnc_auth_fail(vs, vs->auth, "Unsupported version", "");
|
|
vnc_write_u8(vs, 1); /* Reject version */
|
|
vnc_flush(vs);
|
|
vnc_client_error(vs);
|
|
} else {
|
|
vnc_write_u8(vs, 0); /* Accept version */
|
|
vnc_write_u8(vs, 1); /* Number of sub-auths */
|
|
vnc_write_u32(vs, vs->subauth); /* The supported auth */
|
|
vnc_flush(vs);
|
|
vnc_read_when(vs, protocol_client_vencrypt_auth, 4);
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
|
|
void start_auth_vencrypt(VncState *vs)
|
|
{
|
|
/* Send VeNCrypt version 0.2 */
|
|
vnc_write_u8(vs, 0);
|
|
vnc_write_u8(vs, 2);
|
|
|
|
vnc_read_when(vs, protocol_client_vencrypt_init, 2);
|
|
}
|
|
|