qemu/authz
Markus Armbruster 2b37e9f843 authz-list-file: Fix file read error handling
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL.  Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.

qauthz_list_file_complete() is wrong that way: it passes @errp to
qauthz_list_file_complete() without checking for failure.  If it runs
into another failure, it trips error_setv()'s assertion.  Reproducer:

    $ qemu-system-x86_64 -nodefaults -S -display none -object authz-list-file,id=authz0,filename=
    qemu-system-x86_64: ../util/error.c:59: error_setv: Assertion `*errp == NULL' failed.
    Aborted (core dumped)

Fix it to check for failure.

Fixes: 55d869846d
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2020-11-18 10:51:35 +00:00
..
base.c authz: Fix Lesser GPL version number 2020-10-29 09:57:37 +00:00
list.c authz: Fix Lesser GPL version number 2020-10-29 09:57:37 +00:00
listfile.c authz-list-file: Fix file read error handling 2020-11-18 10:51:35 +00:00
meson.build authz: Move the creation of the library to the main meson.build 2020-10-12 11:50:20 -04:00
pamacct.c authz: Fix Lesser GPL version number 2020-10-29 09:57:37 +00:00
simple.c authz: Fix Lesser GPL version number 2020-10-29 09:57:37 +00:00
trace-events trace-events: Fix attribution of trace points to source 2019-03-22 16:18:07 +00:00
trace.h trace: switch position of headers to what Meson requires 2020-08-21 06:18:24 -04:00