No description
Find a file
Pan Nengyuan 2a69314258 i386/kvm: fix a use-after-free when vcpu plug/unplug
When we hotplug vcpus, cpu_update_state is added to vm_change_state_head
in kvm_arch_init_vcpu(). But it forgot to delete in kvm_arch_destroy_vcpu() after
unplug. Then it will cause a use-after-free access. This patch delete it in
kvm_arch_destroy_vcpu() to fix that.

Reproducer:
    virsh setvcpus vm1 4 --live
    virsh setvcpus vm1 2 --live
    virsh suspend vm1
    virsh resume vm1

The UAF stack:
==qemu-system-x86_64==28233==ERROR: AddressSanitizer: heap-use-after-free on address 0x62e00002e798 at pc 0x5573c6917d9e bp 0x7fff07139e50 sp 0x7fff07139e40
WRITE of size 1 at 0x62e00002e798 thread T0
    #0 0x5573c6917d9d in cpu_update_state /mnt/sdb/qemu/target/i386/kvm.c:742
    #1 0x5573c699121a in vm_state_notify /mnt/sdb/qemu/vl.c:1290
    #2 0x5573c636287e in vm_prepare_start /mnt/sdb/qemu/cpus.c:2144
    #3 0x5573c6362927 in vm_start /mnt/sdb/qemu/cpus.c:2150
    #4 0x5573c71e8304 in qmp_cont /mnt/sdb/qemu/monitor/qmp-cmds.c:173
    #5 0x5573c727cb1e in qmp_marshal_cont qapi/qapi-commands-misc.c:835
    #6 0x5573c7694c7a in do_qmp_dispatch /mnt/sdb/qemu/qapi/qmp-dispatch.c:132
    #7 0x5573c7694c7a in qmp_dispatch /mnt/sdb/qemu/qapi/qmp-dispatch.c:175
    #8 0x5573c71d9110 in monitor_qmp_dispatch /mnt/sdb/qemu/monitor/qmp.c:145
    #9 0x5573c71dad4f in monitor_qmp_bh_dispatcher /mnt/sdb/qemu/monitor/qmp.c:234

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200513132630.13412-1-pannengyuan@huawei.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2020-06-10 12:10:01 -04:00
.github
.gitlab-ci.d gitlab-ci: Move edk2 and opensbi YAML files to .gitlab-ci.d folder 2020-05-28 11:00:39 +02:00
accel accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
audio
authz
backends machine queue, 2020-05-13 2020-06-02 10:25:55 +01:00
block block: Factor out bdrv_run_co() 2020-06-05 09:54:48 +01:00
bsd-user
capstone@22ead3e0bf
chardev error: Use error_reportf_err() where appropriate 2020-05-27 07:45:30 +02:00
contrib
crypto
default-configs riscv: Initial commit of OpenTitan machine 2020-06-03 09:11:51 -07:00
disas
docs target-arm queue: 2020-06-05 23:31:31 +01:00
dtc@88f18909db
dump
fpu
fsdev
gdb-xml
hw accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
include accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
io io/task: Move 'qom/object.h' header to source 2020-06-10 12:09:37 -04:00
libdecnumber
linux-headers
linux-user linux-user pull request 20200605-v2 2020-06-08 11:04:57 +01:00
migration accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
monitor
nbd
net
pc-bios
plugins
po
python/qemu python/qemu/qtest: Check before accessing _qtest 2020-05-31 18:25:31 +02:00
qapi qcow2: Expose bitmaps' size during measure 2020-05-28 13:16:16 -05:00
qga
qobject
qom qom/container: remove .instance_size initializer from container_info 2020-06-10 12:09:59 -04:00
replay
roms
scripts run-coverity-scan: support --update-tools-only --docker 2020-06-10 12:09:34 -04:00
scsi error: Use error_reportf_err() where appropriate 2020-05-27 07:45:30 +02:00
slirp@2faae0f778
softmmu accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
storage-daemon
stubs accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
target i386/kvm: fix a use-after-free when vcpu plug/unplug 2020-06-10 12:10:01 -04:00
tcg tcg: Improve move ops in liveness_pass_2 2020-06-02 08:42:37 -07:00
tests io/task: Move 'qom/object.h' header to source 2020-06-10 12:09:37 -04:00
tools/virtiofsd virtiofsd: remove symlink fallbacks 2020-06-01 18:44:27 +01:00
trace
ui
util util/Makefile: Reduce the user-mode object list 2020-06-05 21:23:22 +02:00
.cirrus.yml
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.gitignore
.gitlab-ci.yml gitlab-ci: Determine the number of jobs dynamically 2020-05-28 11:01:38 +02:00
.gitmodules
.gitpublish
.mailmap
.patchew.yml
.readthedocs.yml
.shippable.yml
.travis.yml travis.yml: Use clang++ in the Clang tests 2020-05-27 14:26:47 +01:00
arch_init.c arch_init: Remove unused 'qapi-commands-misc.h' include 2020-06-05 21:23:22 +02:00
balloon.c
block.c
blockdev-nbd.c
blockdev.c
blockjob.c
bootdevice.c
Changelog
CODING_STYLE.rst
configure Makefile: Let the 'help' target list the helper targets 2020-06-10 12:09:38 -04:00
COPYING
COPYING.LIB
cpus-common.c cpus-common: ensure auto-assigned cpu_indexes don't clash 2020-05-27 14:26:49 +01:00
cpus.c cpus: Fix botched configure_icount() error API violation fix 2020-06-10 12:09:59 -04:00
device_tree.c
disas.c
dma-helpers.c
exec-vary.c
exec.c linux-user pull request 20200605-v2 2020-06-08 11:04:57 +01:00
gdbstub.c
gitdm.config
hmp-commands-info.hx
hmp-commands.hx hmp: Simplify qom-set 2020-06-01 18:44:27 +01:00
ioport.c
iothread.c
job-qmp.c
job.c
Kconfig.host
LICENSE
MAINTAINERS accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
Makefile Makefile: Let the 'help' target list the helper targets 2020-06-10 12:09:38 -04:00
Makefile.objs vmbus: vmbus implementation 2020-06-10 12:09:40 -04:00
Makefile.target
memory.c exec: Rename qemu_ram_writeback() as qemu_ram_msync() 2020-06-05 09:54:48 +01:00
memory_ldst.inc.c
memory_mapping.c
module-common.c
os-posix.c
os-win32.c
qdev-monitor.c
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx qemu-img: Add convert --bitmaps option 2020-05-28 13:16:30 -05:00
qemu-img.c qemu-img: Add convert --bitmaps option 2020-05-28 13:16:30 -05:00
qemu-io-cmds.c
qemu-io.c
qemu-keymap.c
qemu-nbd.c error: Use error_reportf_err() where appropriate 2020-05-27 07:45:30 +02:00
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx
qemu-seccomp.c
qemu-storage-daemon.c
qemu.nsi
qemu.sasl
qtest.c
README.rst
replication.c
replication.h
rules.mak
thunk.c
tpm.c
trace-events
VERSION
version.rc

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://qemu.org/Hosts/Linux>`_
* `<https://qemu.org/Hosts/Mac>`_
* `<https://qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://git.qemu.org/git/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the CODING_STYLE.rst file.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://qemu.org/Contribute/SubmitAPatch>`_
* `<https://qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://git.qemu.org/git/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses Launchpad as its primary upstream bug tracker. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://bugs.launchpad.net/qemu/>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via launchpad.

For additional information on bug reporting consult:

* `<https://qemu.org/Contribute/ReportABug>`_


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://qemu.org/Contribute/StartHere>`_