mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-11-05 20:35:44 +00:00
5f50be9b58
If we want to wake up a coroutine from a worker thread, aio_co_wake() currently does not work. In that scenario, aio_co_wake() calls aio_co_enter(), but there is no current AioContext and therefore qemu_get_current_aio_context() returns the main thread. aio_co_wake() then attempts to call aio_context_acquire() instead of going through aio_co_schedule(). The default case of qemu_get_current_aio_context() was added to cover synchronous I/O started from the vCPU thread, but the main and vCPU threads are quite different. The main thread is an I/O thread itself, only running a more complicated event loop; the vCPU thread instead is essentially a worker thread that occasionally calls qemu_mutex_lock_iothread(). It is only in those critical sections that it acts as if it were the home thread of the main AioContext. Therefore, this patch detaches qemu_get_current_aio_context() from iothreads, which is a useless complication. The AioContext pointer is stored directly in the thread-local variable, including for the main loop. Worker threads (including vCPU threads) optionally behave as temporary home threads if they have taken the big QEMU lock, but if that is not the case they will always schedule coroutines on remote threads via aio_co_schedule(). With this change, the stub qemu_mutex_iothread_locked() must be changed from true to false. The previous value of true was needed because the main thread did not have an AioContext in the thread-local variable, but now it does have one. Reported-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Message-Id: <20210609122234.544153-1-pbonzini@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Tested-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> [eblake: tweak commit message per Vladimir's review] Signed-off-by: Eric Blake <eblake@redhat.com> |
||
|---|---|---|
| .. | ||
| arch_type.c | ||
| bdrv-next-monitor-owned.c | ||
| blk-commit-all.c | ||
| blk-exp-close-all.c | ||
| blockdev-close-all-bdrv-states.c | ||
| change-state-handler.c | ||
| cmos.c | ||
| cpu-get-clock.c | ||
| cpu-synchronize-state.c | ||
| cpus-get-virtual-clock.c | ||
| dump.c | ||
| error-printf.c | ||
| fdset.c | ||
| fw_cfg.c | ||
| gdbstub.c | ||
| get-vm-name.c | ||
| icount.c | ||
| io_uring.c | ||
| iothread-lock.c | ||
| is-daemonized.c | ||
| isa-bus.c | ||
| linux-aio.c | ||
| meson.build | ||
| migr-blocker.c | ||
| module-opts.c | ||
| monitor-core.c | ||
| monitor.c | ||
| pci-bus.c | ||
| pci-host-piix.c | ||
| qdev.c | ||
| qemu-timer-notify-cb.c | ||
| qmp-command-available.c | ||
| qmp_memory_device.c | ||
| qtest.c | ||
| ram-block.c | ||
| ramfb.c | ||
| replay-tools.c | ||
| replay.c | ||
| runstate-check.c | ||
| semihost.c | ||
| sysbus.c | ||
| target-get-monitor-def.c | ||
| target-monitor-defs.c | ||
| trace-control.c | ||
| usb-dev-stub.c | ||
| uuid.c | ||
| virtio-gpu-udmabuf.c | ||
| vm-stop.c | ||
| vmgenid.c | ||
| vmstate.c | ||
| win32-kbd-hook.c | ||
| xen-hw-stub.c | ||