qemu/hw/misc/macio
Philippe Mathieu-Daudé 8e5c952b37 hw: Remove unnecessary DEVICE() cast
The DEVICE() macro is defined as:

  #define DEVICE(obj) OBJECT_CHECK(DeviceState, (obj), TYPE_DEVICE)

which expands to:

  ((DeviceState *)object_dynamic_cast_assert((Object *)(obj), (name),
                                             __FILE__, __LINE__,
                                             __func__))

This assertion can only fail when @obj points to something other
than its stated type, i.e. when we're in undefined behavior country.

Remove the unnecessary DEVICE() casts when we already know the
pointer is of DeviceState type.

Patch created mechanically using spatch with this script:

  @@
  typedef DeviceState;
  DeviceState *s;
  @@
  -   DEVICE(s)
  +   s

Acked-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Paul Durrant <paul@xen.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Acked-by: John Snow <jsnow@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200512070020.22782-4-f4bug@amsat.org>
2020-05-15 07:08:52 +02:00
..
cuda.c qdev: set properties with device_class_set_props() 2020-01-24 20:59:15 +01:00
gpio.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
Kconfig kconfig: introduce kconfig files 2019-03-07 21:45:53 +01:00
mac_dbdma.c Include hw/hw.h exactly where needed 2019-08-16 13:31:52 +02:00
macio.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
Makefile.objs mac_newworld: add PMU device 2018-06-16 16:32:33 +10:00
pmu.c hw: Remove unnecessary DEVICE() cast 2020-05-15 07:08:52 +02:00
trace-events trace-events: Delete unused trace points 2019-03-22 16:18:07 +00:00