qemu/hw/pci
Markus Armbruster 9bc6bfdf67 qdev: Drop qbus_set_hotplug_handler() parameter @errp
qbus_set_hotplug_handler() is a simple wrapper around
object_property_set_link().

object_property_set_link() fails when the property doesn't exist, is
not settable, or its .check() method fails.  These are all programming
errors here, so passing &error_abort to qbus_set_hotplug_handler() is
appropriate.

Most of its callers do.  Exceptions:

* pcie_cap_slot_init(), shpc_init(), spapr_phb_realize() pass NULL,
  i.e. they ignore errors.

* spapr_machine_init() passes &error_fatal.

* s390_pcihost_realize(), virtio_serial_device_realize(),
  s390_pcihost_plug() pass the error to their callers.  The latter two
  keep going after the error, which looks wrong.

Drop the @errp parameter, and instead pass &error_abort to
object_property_set_link().

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200630090351.1247703-15-armbru@redhat.com>
2020-07-02 06:25:29 +02:00
..
Kconfig kconfig: add CONFIG_MSI_NONBROKEN 2019-03-18 09:39:57 +01:00
Makefile.objs hw/pci/Makefile.objs: make pcie configurable 2019-03-07 21:45:53 +01:00
msi.c pci/msi: export msi_is_masked() 2019-02-05 10:58:33 -05:00
msix.c * Miscellaneous fixes and feature enablement (many) 2020-06-12 23:06:22 +01:00
pci-stub.c pci-stub: add more MSI functions 2019-12-17 19:33:49 +01:00
pci.c pci: Delete useless error_propagate() 2020-07-02 06:25:28 +02:00
pci_bridge.c hw/pci/pci_bridge: Use the IEC binary prefix definitions 2020-06-09 14:18:04 -04:00
pci_host.c hw/pci/pci_host: Let pci_data_[read/write] use unsigned 'size' argument 2020-01-05 07:03:03 -05:00
pcie.c qdev: Drop qbus_set_hotplug_handler() parameter @errp 2020-07-02 06:25:29 +02:00
pcie_aer.c Include migration/vmstate.h less 2019-08-16 13:31:52 +02:00
pcie_host.c Include hw/hw.h exactly where needed 2019-08-16 13:31:52 +02:00
pcie_port.c pcie_root_port: Add hotplug disabling option 2020-03-08 09:18:29 -04:00
shpc.c qdev: Drop qbus_set_hotplug_handler() parameter @errp 2020-07-02 06:25:29 +02:00
slotid_cap.c pci: Convert shpc_init() to Error 2017-07-03 22:29:49 +03:00
trace-events trace-events: Shorten file names in comments 2019-03-22 16:18:07 +00:00