mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 18:05:37 +00:00
![Daniel P. Berrange](/assets/img/avatar_default.png)
The TraceEventID and TraceEventVCPUID enums constants are no longer actually used for anything critical. The TRACE_EVENT_COUNT limit is used to determine the size of the TraceEvents array, and can be removed if we just NULL terminate the array instead. The TRACE_VCPU_EVENT_COUNT limit is used as a magic value for marking non-vCPU events, and also for declaring the size of the trace dstate mask in the CPUState struct. The former usage can be replaced by a dedicated constant TRACE_EVENT_VCPU_NONE, defined as (uint32_t)-1. For the latter usage, we can simply define a constant for the number of VCPUs, avoiding the need for the full enum. The only other usages of the enum values can be replaced by accesing the id/vcpu_id fields via the named TraceEvent structs. Reviewed-by: Lluís Vilanova <vilanova@ac.upc.edu> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Daniel P. Berrange <berrange@redhat.com> Message-id: 1475588159-30598-11-git-send-email-berrange@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
45 lines
1.2 KiB
C
45 lines
1.2 KiB
C
/*
|
|
* Interface for configuring and controlling the state of tracing events.
|
|
*
|
|
* Copyright (C) 2012-2016 Lluís Vilanova <vilanova@ac.upc.edu>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#ifndef TRACE__EVENT_INTERNAL_H
|
|
#define TRACE__EVENT_INTERNAL_H
|
|
|
|
/*
|
|
* Special value for TraceEvent.vcpu_id field to indicate
|
|
* that the event is not VCPU specific
|
|
*/
|
|
#define TRACE_VCPU_EVENT_NONE ((uint32_t)-1)
|
|
|
|
/**
|
|
* TraceEvent:
|
|
* @id: Unique event identifier.
|
|
* @vcpu_id: Unique per-vCPU event identifier.
|
|
* @name: Event name.
|
|
* @sstate: Static tracing state.
|
|
* @dstate: Dynamic tracing state
|
|
*
|
|
* Interpretation of @dstate depends on whether the event has the 'vcpu'
|
|
* property:
|
|
* - false: Boolean value indicating whether the event is active.
|
|
* - true : Integral counting the number of vCPUs that have this event enabled.
|
|
*
|
|
* Opaque generic description of a tracing event.
|
|
*/
|
|
typedef struct TraceEvent {
|
|
uint32_t id;
|
|
uint32_t vcpu_id;
|
|
const char * name;
|
|
const bool sstate;
|
|
uint16_t *dstate;
|
|
} TraceEvent;
|
|
|
|
void trace_event_set_state_dynamic_init(TraceEvent *ev, bool state);
|
|
|
|
#endif /* TRACE__EVENT_INTERNAL_H */
|