mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 01:43:39 +00:00
![Eric Blake](/assets/img/avatar_default.png)
There are many existing qcow2 images that specify a backing file but no format. This has been the source of CVEs in the past, but has become more prominent of a problem now that libvirt has switched to -blockdev. With older -drive, at least the probing was always done by qemu (so the only risk of a changed format between successive boots of a guest was if qemu was upgraded and probed differently). But with newer -blockdev, libvirt must specify a format; if libvirt guesses raw where the image was formatted, this results in data corruption visible to the guest; conversely, if libvirt guesses qcow2 where qemu was using raw, this can result in potential security holes, so modern libvirt instead refuses to use images without explicit backing format. The change in libvirt to reject images without explicit backing format has pointed out that a number of tools have been far too reliant on probing in the past. It's time to set a better example in our own iotests of properly setting this parameter. iotest calls to create, rebase, and convert are all impacted to some degree. It's a bit annoying that we are inconsistent on command line - while all of those accept -o backing_file=...,backing_fmt=..., the shortcuts are different: create and rebase have -b and -F, while convert has -B but no -F. (amend has no shortcuts, but the previous patch just deprecated the use of amend to change backing chains). Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20200706203954.341758-9-eblake@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
157 lines
9.9 KiB
Plaintext
157 lines
9.9 KiB
Plaintext
QA output created by 179
|
|
|
|
=== Testing write zeroes with unmap ===
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=67108864
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
|
|
wrote 2097152/2097152 bytes at offset 2097152
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 6291456
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
2 MiB (0x200000) bytes not allocated at offset 0 bytes (0x0)
|
|
2 MiB (0x200000) bytes allocated at offset 2 MiB (0x200000)
|
|
2 MiB (0x200000) bytes not allocated at offset 4 MiB (0x400000)
|
|
2 MiB (0x200000) bytes allocated at offset 6 MiB (0x600000)
|
|
56 MiB (0x3800000) bytes not allocated at offset 8 MiB (0x800000)
|
|
[{ "start": 0, "length": 67108864, "depth": 0, "zero": true, "data": false}]
|
|
wrote 2097150/2097150 bytes at offset 10485761
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097150/2097150 bytes at offset 14680065
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
2 MiB (0x200000) bytes not allocated at offset 0 bytes (0x0)
|
|
2 MiB (0x200000) bytes allocated at offset 2 MiB (0x200000)
|
|
2 MiB (0x200000) bytes not allocated at offset 4 MiB (0x400000)
|
|
2 MiB (0x200000) bytes allocated at offset 6 MiB (0x600000)
|
|
2 MiB (0x200000) bytes not allocated at offset 8 MiB (0x800000)
|
|
2 MiB (0x200000) bytes allocated at offset 10 MiB (0xa00000)
|
|
2 MiB (0x200000) bytes not allocated at offset 12 MiB (0xc00000)
|
|
2 MiB (0x200000) bytes allocated at offset 14 MiB (0xe00000)
|
|
48 MiB (0x3000000) bytes not allocated at offset 16 MiB (0x1000000)
|
|
[{ "start": 0, "length": 67108864, "depth": 0, "zero": true, "data": false}]
|
|
wrote 14680064/14680064 bytes at offset 18874368
|
|
14 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 20971520
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 6291456/6291456 bytes at offset 25165824
|
|
6 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
2 MiB (0x200000) bytes not allocated at offset 0 bytes (0x0)
|
|
2 MiB (0x200000) bytes allocated at offset 2 MiB (0x200000)
|
|
2 MiB (0x200000) bytes not allocated at offset 4 MiB (0x400000)
|
|
2 MiB (0x200000) bytes allocated at offset 6 MiB (0x600000)
|
|
2 MiB (0x200000) bytes not allocated at offset 8 MiB (0x800000)
|
|
2 MiB (0x200000) bytes allocated at offset 10 MiB (0xa00000)
|
|
2 MiB (0x200000) bytes not allocated at offset 12 MiB (0xc00000)
|
|
2 MiB (0x200000) bytes allocated at offset 14 MiB (0xe00000)
|
|
2 MiB (0x200000) bytes not allocated at offset 16 MiB (0x1000000)
|
|
14 MiB (0xe00000) bytes allocated at offset 18 MiB (0x1200000)
|
|
32 MiB (0x2000000) bytes not allocated at offset 32 MiB (0x2000000)
|
|
[{ "start": 0, "length": 18874368, "depth": 0, "zero": true, "data": false},
|
|
{ "start": 18874368, "length": 2097152, "depth": 0, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 20971520, "length": 2097152, "depth": 0, "zero": true, "data": false},
|
|
{ "start": 23068672, "length": 2097152, "depth": 0, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 25165824, "length": 6291456, "depth": 0, "zero": true, "data": false, "offset": OFFSET},
|
|
{ "start": 31457280, "length": 2097152, "depth": 0, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 33554432, "length": 33554432, "depth": 0, "zero": true, "data": false}]
|
|
wrote 2097152/2097152 bytes at offset 27262976
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 29360128
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
2 MiB (0x200000) bytes not allocated at offset 0 bytes (0x0)
|
|
2 MiB (0x200000) bytes allocated at offset 2 MiB (0x200000)
|
|
2 MiB (0x200000) bytes not allocated at offset 4 MiB (0x400000)
|
|
2 MiB (0x200000) bytes allocated at offset 6 MiB (0x600000)
|
|
2 MiB (0x200000) bytes not allocated at offset 8 MiB (0x800000)
|
|
2 MiB (0x200000) bytes allocated at offset 10 MiB (0xa00000)
|
|
2 MiB (0x200000) bytes not allocated at offset 12 MiB (0xc00000)
|
|
2 MiB (0x200000) bytes allocated at offset 14 MiB (0xe00000)
|
|
2 MiB (0x200000) bytes not allocated at offset 16 MiB (0x1000000)
|
|
14 MiB (0xe00000) bytes allocated at offset 18 MiB (0x1200000)
|
|
32 MiB (0x2000000) bytes not allocated at offset 32 MiB (0x2000000)
|
|
[{ "start": 0, "length": 18874368, "depth": 0, "zero": true, "data": false},
|
|
{ "start": 18874368, "length": 2097152, "depth": 0, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 20971520, "length": 2097152, "depth": 0, "zero": true, "data": false},
|
|
{ "start": 23068672, "length": 2097152, "depth": 0, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 25165824, "length": 2097152, "depth": 0, "zero": true, "data": false, "offset": OFFSET},
|
|
{ "start": 27262976, "length": 2097152, "depth": 0, "zero": true, "data": false},
|
|
{ "start": 29360128, "length": 2097152, "depth": 0, "zero": true, "data": false, "offset": OFFSET},
|
|
{ "start": 31457280, "length": 2097152, "depth": 0, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 33554432, "length": 33554432, "depth": 0, "zero": true, "data": false}]
|
|
wrote 8388608/8388608 bytes at offset 33554432
|
|
8 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 35651584
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 37748736
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
2 MiB (0x200000) bytes not allocated at offset 0 bytes (0x0)
|
|
2 MiB (0x200000) bytes allocated at offset 2 MiB (0x200000)
|
|
2 MiB (0x200000) bytes not allocated at offset 4 MiB (0x400000)
|
|
2 MiB (0x200000) bytes allocated at offset 6 MiB (0x600000)
|
|
2 MiB (0x200000) bytes not allocated at offset 8 MiB (0x800000)
|
|
2 MiB (0x200000) bytes allocated at offset 10 MiB (0xa00000)
|
|
2 MiB (0x200000) bytes not allocated at offset 12 MiB (0xc00000)
|
|
2 MiB (0x200000) bytes allocated at offset 14 MiB (0xe00000)
|
|
2 MiB (0x200000) bytes not allocated at offset 16 MiB (0x1000000)
|
|
22 MiB (0x1600000) bytes allocated at offset 18 MiB (0x1200000)
|
|
24 MiB (0x1800000) bytes not allocated at offset 40 MiB (0x2800000)
|
|
[{ "start": 0, "length": 18874368, "depth": 0, "zero": true, "data": false},
|
|
{ "start": 18874368, "length": 2097152, "depth": 0, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 20971520, "length": 2097152, "depth": 0, "zero": true, "data": false},
|
|
{ "start": 23068672, "length": 2097152, "depth": 0, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 25165824, "length": 2097152, "depth": 0, "zero": true, "data": false, "offset": OFFSET},
|
|
{ "start": 27262976, "length": 2097152, "depth": 0, "zero": true, "data": false},
|
|
{ "start": 29360128, "length": 2097152, "depth": 0, "zero": true, "data": false, "offset": OFFSET},
|
|
{ "start": 31457280, "length": 2097152, "depth": 0, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 33554432, "length": 33554432, "depth": 0, "zero": true, "data": false}]
|
|
wrote 8388608/8388608 bytes at offset 41943040
|
|
8 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 8388608/8388608 bytes at offset 50331648
|
|
8 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 44040192
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 46137344
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 52428800
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 54525952
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 60817408
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 62914560
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
42 MiB (0x2a00000) bytes not allocated at offset 0 bytes (0x0)
|
|
4 MiB (0x400000) bytes allocated at offset 42 MiB (0x2a00000)
|
|
4 MiB (0x400000) bytes not allocated at offset 46 MiB (0x2e00000)
|
|
4 MiB (0x400000) bytes allocated at offset 50 MiB (0x3200000)
|
|
4 MiB (0x400000) bytes not allocated at offset 54 MiB (0x3600000)
|
|
4 MiB (0x400000) bytes allocated at offset 58 MiB (0x3a00000)
|
|
2 MiB (0x200000) bytes not allocated at offset 62 MiB (0x3e00000)
|
|
[{ "start": 0, "length": 18874368, "depth": 1, "zero": true, "data": false},
|
|
{ "start": 18874368, "length": 2097152, "depth": 1, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 20971520, "length": 2097152, "depth": 1, "zero": true, "data": false},
|
|
{ "start": 23068672, "length": 2097152, "depth": 1, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 25165824, "length": 2097152, "depth": 1, "zero": true, "data": false, "offset": OFFSET},
|
|
{ "start": 27262976, "length": 2097152, "depth": 1, "zero": true, "data": false},
|
|
{ "start": 29360128, "length": 2097152, "depth": 1, "zero": true, "data": false, "offset": OFFSET},
|
|
{ "start": 31457280, "length": 2097152, "depth": 1, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 33554432, "length": 10485760, "depth": 1, "zero": true, "data": false},
|
|
{ "start": 44040192, "length": 4194304, "depth": 0, "zero": true, "data": false},
|
|
{ "start": 48234496, "length": 2097152, "depth": 1, "zero": true, "data": false},
|
|
{ "start": 50331648, "length": 2097152, "depth": 1, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 52428800, "length": 4194304, "depth": 0, "zero": true, "data": false},
|
|
{ "start": 56623104, "length": 2097152, "depth": 1, "zero": false, "data": true, "offset": OFFSET},
|
|
{ "start": 58720256, "length": 2097152, "depth": 1, "zero": true, "data": false},
|
|
{ "start": 60817408, "length": 4194304, "depth": 0, "zero": true, "data": false},
|
|
{ "start": 65011712, "length": 2097152, "depth": 1, "zero": true, "data": false}]
|
|
No errors were found on the image.
|
|
No errors were found on the image.
|
|
|
|
=== Testing cache optimization ===
|
|
|
|
wrote 2097152/2097152 bytes at offset 20971520
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 20971520
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 2097152/2097152 bytes at offset 29360128
|
|
2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
*** done
|