mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 18:05:37 +00:00
tcg/tci: Use g_assert_not_reached
Three TODO instances are never happen cases. Other uses of tcg_abort are also indicating unreachable cases. Tested-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Stefan Weil <sw@weilnetz.de> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
parent
b4d5bf0f9b
commit
f6996f99f3
15
tcg/tci.c
15
tcg/tci.c
|
@ -362,7 +362,7 @@ static bool tci_compare32(uint32_t u0, uint32_t u1, TCGCond condition)
|
|||
result = (u0 > u1);
|
||||
break;
|
||||
default:
|
||||
TODO();
|
||||
g_assert_not_reached();
|
||||
}
|
||||
return result;
|
||||
}
|
||||
|
@ -404,7 +404,7 @@ static bool tci_compare64(uint64_t u0, uint64_t u1, TCGCond condition)
|
|||
result = (u0 > u1);
|
||||
break;
|
||||
default:
|
||||
TODO();
|
||||
g_assert_not_reached();
|
||||
}
|
||||
return result;
|
||||
}
|
||||
|
@ -1114,7 +1114,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env,
|
|||
tmp32 = qemu_ld_beul;
|
||||
break;
|
||||
default:
|
||||
tcg_abort();
|
||||
g_assert_not_reached();
|
||||
}
|
||||
tci_write_reg(regs, t0, tmp32);
|
||||
break;
|
||||
|
@ -1163,7 +1163,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env,
|
|||
tmp64 = qemu_ld_beq;
|
||||
break;
|
||||
default:
|
||||
tcg_abort();
|
||||
g_assert_not_reached();
|
||||
}
|
||||
tci_write_reg(regs, t0, tmp64);
|
||||
if (TCG_TARGET_REG_BITS == 32) {
|
||||
|
@ -1191,7 +1191,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env,
|
|||
qemu_st_bel(t0);
|
||||
break;
|
||||
default:
|
||||
tcg_abort();
|
||||
g_assert_not_reached();
|
||||
}
|
||||
break;
|
||||
case INDEX_op_qemu_st_i64:
|
||||
|
@ -1221,7 +1221,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env,
|
|||
qemu_st_beq(tmp64);
|
||||
break;
|
||||
default:
|
||||
tcg_abort();
|
||||
g_assert_not_reached();
|
||||
}
|
||||
break;
|
||||
case INDEX_op_mb:
|
||||
|
@ -1229,8 +1229,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env,
|
|||
smp_mb();
|
||||
break;
|
||||
default:
|
||||
TODO();
|
||||
break;
|
||||
g_assert_not_reached();
|
||||
}
|
||||
tci_assert(tb_ptr == old_code_ptr + op_size);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue