mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 18:05:37 +00:00
tests/plugin: Remove duplicate insn log from libinsn.so
This is a perfectly natural occurrence for x86 "rep movb", where the "rep" prefix forms a counted loop of the one insn. During the tests/tcg/multiarch/memory test, this logging is triggered over 350000 times. Within the context of cross-i386-tci build, which is already slow by nature, the logging is sufficient to push the test into timeout. Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
parent
1d3daf9525
commit
ea185a557b
|
@ -19,7 +19,6 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_version = QEMU_PLUGIN_VERSION;
|
|||
#define MAX_CPUS 8 /* lets not go nuts */
|
||||
|
||||
typedef struct {
|
||||
uint64_t last_pc;
|
||||
uint64_t insn_count;
|
||||
} InstructionCount;
|
||||
|
||||
|
@ -51,13 +50,7 @@ static void vcpu_insn_exec_before(unsigned int cpu_index, void *udata)
|
|||
{
|
||||
unsigned int i = cpu_index % MAX_CPUS;
|
||||
InstructionCount *c = &counts[i];
|
||||
uint64_t this_pc = GPOINTER_TO_UINT(udata);
|
||||
if (this_pc == c->last_pc) {
|
||||
g_autofree gchar *out = g_strdup_printf("detected repeat execution @ 0x%"
|
||||
PRIx64 "\n", this_pc);
|
||||
qemu_plugin_outs(out);
|
||||
}
|
||||
c->last_pc = this_pc;
|
||||
|
||||
c->insn_count++;
|
||||
}
|
||||
|
||||
|
|
|
@ -33,14 +33,5 @@ EXTRA_RUNS+=$(MULTIARCH_RUNS)
|
|||
|
||||
memory: CFLAGS+=-DCHECK_UNALIGNED=1
|
||||
|
||||
# non-inline runs will trigger the duplicate instruction heuristics in libinsn.so
|
||||
run-plugin-%-with-libinsn.so:
|
||||
$(call run-test, $@, \
|
||||
$(QEMU) -monitor none -display none \
|
||||
-chardev file$(COMMA)path=$@.out$(COMMA)id=output \
|
||||
-plugin ../../plugin/libinsn.so$(COMMA)inline=on \
|
||||
-d plugin -D $*-with-libinsn.so.pout \
|
||||
$(QEMU_OPTS) $*)
|
||||
|
||||
# Running
|
||||
QEMU_OPTS+=-device isa-debugcon,chardev=output -device isa-debug-exit,iobase=0xf4,iosize=0x4 -kernel
|
||||
|
|
|
@ -63,12 +63,6 @@ else
|
|||
SKIP_I386_TESTS+=test-i386-fprem
|
||||
endif
|
||||
|
||||
# non-inline runs will trigger the duplicate instruction heuristics in libinsn.so
|
||||
run-plugin-%-with-libinsn.so:
|
||||
$(call run-test, $@, $(QEMU) $(QEMU_OPTS) \
|
||||
-plugin ../../plugin/libinsn.so$(COMMA)inline=on \
|
||||
-d plugin -D $*-with-libinsn.so.pout $*)
|
||||
|
||||
# Update TESTS
|
||||
I386_TESTS:=$(filter-out $(SKIP_I386_TESTS), $(ALL_X86_TESTS))
|
||||
TESTS=$(MULTIARCH_TESTS) $(I386_TESTS)
|
||||
|
|
|
@ -33,14 +33,5 @@ EXTRA_RUNS+=$(MULTIARCH_RUNS)
|
|||
|
||||
memory: CFLAGS+=-DCHECK_UNALIGNED=1
|
||||
|
||||
# non-inline runs will trigger the duplicate instruction heuristics in libinsn.so
|
||||
run-plugin-%-with-libinsn.so:
|
||||
$(call run-test, $@, \
|
||||
$(QEMU) -monitor none -display none \
|
||||
-chardev file$(COMMA)path=$@.out$(COMMA)id=output \
|
||||
-plugin ../../plugin/libinsn.so$(COMMA)inline=on \
|
||||
-d plugin -D $*-with-libinsn.so.pout \
|
||||
$(QEMU_OPTS) $*)
|
||||
|
||||
# Running
|
||||
QEMU_OPTS+=-device isa-debugcon,chardev=output -device isa-debug-exit,iobase=0xf4,iosize=0x4 -kernel
|
||||
|
|
Loading…
Reference in a new issue