mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-10-15 07:22:46 +00:00
block: Fail bdrv_truncate() with negative size
Most callers have their own checks, but something like this should also be checked centrally. As it happens, x-blockdev-create can pass negative image sizes to format drivers (because there is no QAPI type that would reject negative numbers) and triggers the check added by this patch. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
parent
89b259eeaa
commit
cd8b7aaa07
5
block.c
5
block.c
|
@ -3719,6 +3719,11 @@ int bdrv_truncate(BdrvChild *child, int64_t offset, PreallocMode prealloc,
|
||||||
error_setg(errp, "No medium inserted");
|
error_setg(errp, "No medium inserted");
|
||||||
return -ENOMEDIUM;
|
return -ENOMEDIUM;
|
||||||
}
|
}
|
||||||
|
if (offset < 0) {
|
||||||
|
error_setg(errp, "Image size cannot be negative");
|
||||||
|
return -EINVAL;
|
||||||
|
}
|
||||||
|
|
||||||
if (!drv->bdrv_truncate) {
|
if (!drv->bdrv_truncate) {
|
||||||
if (bs->file && drv->is_filter) {
|
if (bs->file && drv->is_filter) {
|
||||||
return bdrv_truncate(bs->file, offset, prealloc, errp);
|
return bdrv_truncate(bs->file, offset, prealloc, errp);
|
||||||
|
|
Loading…
Reference in a new issue