system/qemu
system/qemu
1
0
Fork 0
mirror of https://gitlab.com/qemu-project/qemu synced 2024-07-22 02:44:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

qga: return a more explicit error on why a command is disabled

Browse source 
qmp_disable_command() now takes an optional error string to return a
more explicit error message.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1928806

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
*fix up 80+ char line
Signed-off-by: Michael Roth <michael.roth@amd.com>
This commit is contained in:
Marc-André Lureau 2021-02-19 12:28:14 +04:00 committed by Michael Roth
parent 86dc17d4d0
commit c98939daec
4 changed files with 15 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
include/qapi/qmp/dispatch.h
View file

@ -36,6 +36,7 @@ typedef struct QmpCommand
QmpCommandOptions options; QmpCommandOptions options;
QTAILQ_ENTRY(QmpCommand) node; QTAILQ_ENTRY(QmpCommand) node;
bool enabled; bool enabled;
const char *disable_reason;
} QmpCommand; } QmpCommand;
typedef QTAILQ_HEAD(QmpCommandList, QmpCommand) QmpCommandList; typedef QTAILQ_HEAD(QmpCommandList, QmpCommand) QmpCommandList;
@ -44,7 +45,8 @@ void qmp_register_command(QmpCommandList *cmds, const char *name,
QmpCommandFunc *fn, QmpCommandOptions options); QmpCommandFunc *fn, QmpCommandOptions options);
const QmpCommand *qmp_find_command(const QmpCommandList *cmds, const QmpCommand *qmp_find_command(const QmpCommandList *cmds,
const char *name); const char *name);
void qmp_disable_command(QmpCommandList *cmds, const char *name); void qmp_disable_command(QmpCommandList *cmds, const char *name,
const char *err_msg);
void qmp_enable_command(QmpCommandList *cmds, const char *name); void qmp_enable_command(QmpCommandList *cmds, const char *name);
bool qmp_command_is_enabled(const QmpCommand *cmd); bool qmp_command_is_enabled(const QmpCommand *cmd);

6
qapi/qmp-dispatch.c
View file

@ -157,8 +157,10 @@ QDict *qmp_dispatch(const QmpCommandList *cmds, QObject *request,
} }
if (!cmd->enabled) { if (!cmd->enabled) {
error_set(&err, ERROR_CLASS_COMMAND_NOT_FOUND, error_set(&err, ERROR_CLASS_COMMAND_NOT_FOUND,
"The command %s has been disabled for this instance", "Command %s has been disabled%s%s",
command); command,
cmd->disable_reason ? ": " : "",
cmd->disable_reason ?: "");
goto out; goto out;
} }
if (oob && !(cmd->options & QCO_ALLOW_OOB)) { if (oob && !(cmd->options & QCO_ALLOW_OOB)) {

10
qapi/qmp-registry.c
View file

@ -43,26 +43,28 @@ const QmpCommand *qmp_find_command(const QmpCommandList *cmds, const char *name)
} }
static void qmp_toggle_command(QmpCommandList *cmds, const char *name, static void qmp_toggle_command(QmpCommandList *cmds, const char *name,
bool enabled) bool enabled, const char *disable_reason)
{ {
QmpCommand *cmd; QmpCommand *cmd;
QTAILQ_FOREACH(cmd, cmds, node) { QTAILQ_FOREACH(cmd, cmds, node) {
if (strcmp(cmd->name, name) == 0) { if (strcmp(cmd->name, name) == 0) {
cmd->enabled = enabled; cmd->enabled = enabled;
cmd->disable_reason = disable_reason;
return; return;
} }
} }
} }
void qmp_disable_command(QmpCommandList *cmds, const char *name) void qmp_disable_command(QmpCommandList *cmds, const char *name,
const char *disable_reason)
{ {
qmp_toggle_command(cmds, name, false); qmp_toggle_command(cmds, name, false, disable_reason);
} }
void qmp_enable_command(QmpCommandList *cmds, const char *name) void qmp_enable_command(QmpCommandList *cmds, const char *name)
{ {
qmp_toggle_command(cmds, name, true); qmp_toggle_command(cmds, name, true, NULL);
} }
bool qmp_command_is_enabled(const QmpCommand *cmd) bool qmp_command_is_enabled(const QmpCommand *cmd)

4
qga/main.c
View file

@ -375,7 +375,7 @@ static void ga_disable_non_whitelisted(const QmpCommand *cmd, void *opaque)
} }
if (!whitelisted) { if (!whitelisted) {
g_debug("disabling command: %s", name); g_debug("disabling command: %s", name);
qmp_disable_command(&ga_commands, name); qmp_disable_command(&ga_commands, name, "the agent is in frozen state");
} }
} }
@ -1328,7 +1328,7 @@ static GAState *initialize_agent(GAConfig *config, int socket_activation)
s->blacklist = config->blacklist; s->blacklist = config->blacklist;
do { do {
g_debug("disabling command: %s", (char *)l->data); g_debug("disabling command: %s", (char *)l->data);
qmp_disable_command(&ga_commands, l->data); qmp_disable_command(&ga_commands, l->data, NULL);
l = g_list_next(l); l = g_list_next(l);
} while (l); } while (l);
} }