mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 18:05:37 +00:00
vfio-pci: Fix error path sign
This is an impossible error path due to the fact that we're reading a kernel provided, rather than user provided link, which will certainly always fit in PATH_MAX. Currently it returns a fixed 26 char path plus %d group number, which typically maxes out at double digits. However, the caller of the initfn certainly expects a less-than zero return value on error, not just a non-zero value. Therefore we should correct the sign here. Reported-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Laszlo Ersek <lersek@redhat.com> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
This commit is contained in:
parent
07ceaf9880
commit
c6d231e2fd
|
@ -3358,7 +3358,7 @@ static int vfio_initfn(PCIDevice *pdev)
|
|||
len = readlink(path, iommu_group_path, sizeof(path));
|
||||
if (len <= 0 || len >= sizeof(path)) {
|
||||
error_report("vfio: error no iommu_group for device");
|
||||
return len < 0 ? -errno : ENAMETOOLONG;
|
||||
return len < 0 ? -errno : -ENAMETOOLONG;
|
||||
}
|
||||
|
||||
iommu_group_path[len] = 0;
|
||||
|
|
Loading…
Reference in a new issue