From c06b1571cc5c27b2042315b2a1c99f477a497716 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Wed, 7 Jun 2023 10:01:03 +0200 Subject: [PATCH] configure: check for $download value properly If configure was invoked with --disable-download and git submodules were not checked out a warning is produced and the configure script fails. But the $download variable (which reflects the enable/disable download argument) is checked for in a weird fashion: test -f "$download" = disabled Drop the '-f' to check for the actual value of the variable. Fixes: 2019cabfee0 ("meson: subprojects: replace submodules with wrap files", 2023-06-06) Signed-off-by: Michal Privoznik Signed-off-by: Paolo Bonzini --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 8765b88e12..8a638dd82a 100755 --- a/configure +++ b/configure @@ -767,7 +767,7 @@ if test "$plugins" = "yes" -a "$tcg" = "disabled"; then fi if ! test -f "$source_path/subprojects/keycodemapdb/README" \ - && test -f "$download" = disabled + && test "$download" = disabled then echo echo "ERROR: missing subprojects"