mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 18:05:37 +00:00
tests: Avoid side effects inside g_assert() arguments
For us, assertions are always enabled, but side-effect expressions inside the argument to g_assert() are bad style anyway. Fix three occurrences in IPMI related tests, which will silence some Coverity nits. Fixes: CID 1432322, CID 1432287, CID 1432291 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Message-Id: <20210503165525.26221-4-peter.maydell@linaro.org> Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
parent
6c054176db
commit
bfaa3b05a9
|
@ -98,7 +98,8 @@ static void bt_wait_b_busy(void)
|
||||||
{
|
{
|
||||||
unsigned int count = 1000;
|
unsigned int count = 1000;
|
||||||
while (IPMI_BT_CTLREG_GET_B_BUSY() != 0) {
|
while (IPMI_BT_CTLREG_GET_B_BUSY() != 0) {
|
||||||
g_assert(--count != 0);
|
--count;
|
||||||
|
g_assert(count != 0);
|
||||||
usleep(100);
|
usleep(100);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -107,7 +108,8 @@ static void bt_wait_b2h_atn(void)
|
||||||
{
|
{
|
||||||
unsigned int count = 1000;
|
unsigned int count = 1000;
|
||||||
while (IPMI_BT_CTLREG_GET_B2H_ATN() == 0) {
|
while (IPMI_BT_CTLREG_GET_B2H_ATN() == 0) {
|
||||||
g_assert(--count != 0);
|
--count;
|
||||||
|
g_assert(count != 0);
|
||||||
usleep(100);
|
usleep(100);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -73,7 +73,8 @@ static void kcs_wait_ibf(void)
|
||||||
{
|
{
|
||||||
unsigned int count = 1000;
|
unsigned int count = 1000;
|
||||||
while (IPMI_KCS_CMDREG_GET_IBF() != 0) {
|
while (IPMI_KCS_CMDREG_GET_IBF() != 0) {
|
||||||
g_assert(--count != 0);
|
--count;
|
||||||
|
g_assert(count != 0);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue