mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 18:05:37 +00:00
qapi: shortcut visits on errors
We can exit very soon if we enter a visitor with a preexisting error. This simplifies some cases because we will not have to deal with obj being non-NULL while *obj is NULL. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Anthony Liguori <aliguori@us.ibm.com> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
This commit is contained in:
parent
8b714d3747
commit
b6f0474fc0
|
@ -61,6 +61,9 @@ def generate_visit_struct(name, members):
|
|||
|
||||
void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **errp)
|
||||
{
|
||||
if (error_is_set(errp)) {
|
||||
return;
|
||||
}
|
||||
visit_start_struct(m, (void **)obj, "%(name)s", name, sizeof(%(name)s), errp);
|
||||
''',
|
||||
name=name)
|
||||
|
@ -81,6 +84,9 @@ def generate_visit_list(name, members):
|
|||
{
|
||||
GenericList *i, **head = (GenericList **)obj;
|
||||
|
||||
if (error_is_set(errp)) {
|
||||
return;
|
||||
}
|
||||
visit_start_list(m, name, errp);
|
||||
|
||||
for (*head = i = visit_next_list(m, head, errp); i; i = visit_next_list(m, &i, errp)) {
|
||||
|
@ -112,6 +118,9 @@ def generate_visit_union(name, members):
|
|||
{
|
||||
Error *err = NULL;
|
||||
|
||||
if (error_is_set(errp)) {
|
||||
return;
|
||||
}
|
||||
visit_start_struct(m, (void **)obj, "%(name)s", name, sizeof(%(name)s), &err);
|
||||
visit_type_%(name)sKind(m, &(*obj)->kind, "type", &err);
|
||||
if (err) {
|
||||
|
|
Loading…
Reference in a new issue