system/qemu
system/qemu
1
0
Fork 0
mirror of https://gitlab.com/qemu-project/qemu synced 2024-11-05 20:35:44 +00:00
Code Issues Projects Releases Packages Wiki Activity

test-keyval: Tweaks to improve list coverage

Browse source 
We have a negative test case for a list index with leading zero.  Add
positive ones.

Tweak the test case for list index greater or equal the number of
elements: test "equal" instead of "greater" to guard against
off-by-one mistakes.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1490014548-15083-2-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Markus Armbruster 2017-03-20 13:55:44 +01:00
parent 940a8ce075
commit b2cd5b925c
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/test-keyval.c
View file

@ -218,14 +218,14 @@ static void test_keyval_parse_list(void)
QDECREF(qdict); QDECREF(qdict);
/* Multiple indexes, last one wins */ /* Multiple indexes, last one wins */
qdict = keyval_parse("list.1=goner,list.0=null,list.1=eins,list.2=zwei", qdict = keyval_parse("list.1=goner,list.0=null,list.01=eins,list.2=zwei",
NULL, &error_abort); NULL, &error_abort);
g_assert_cmpint(qdict_size(qdict), ==, 1); g_assert_cmpint(qdict_size(qdict), ==, 1);
check_list012(qdict_get_qlist(qdict, "list")); check_list012(qdict_get_qlist(qdict, "list"));
QDECREF(qdict); QDECREF(qdict);
/* List at deeper nesting */ /* List at deeper nesting */
qdict = keyval_parse("a.list.1=eins,a.list.0=null,a.list.2=zwei", qdict = keyval_parse("a.list.1=eins,a.list.00=null,a.list.2=zwei",
NULL, &error_abort); NULL, &error_abort);
g_assert_cmpint(qdict_size(qdict), ==, 1); g_assert_cmpint(qdict_size(qdict), ==, 1);
sub_qdict = qdict_get_qdict(qdict, "a"); sub_qdict = qdict_get_qdict(qdict, "a");
@ -242,7 +242,7 @@ static void test_keyval_parse_list(void)
g_assert(!qdict); g_assert(!qdict);
/* Missing list indexes */ /* Missing list indexes */
qdict = keyval_parse("list.2=lonely", NULL, &err); qdict = keyval_parse("list.1=lonely", NULL, &err);
error_free_or_abort(&err); error_free_or_abort(&err);
g_assert(!qdict); g_assert(!qdict);
qdict = keyval_parse("list.0=null,list.2=eins,list.02=zwei", NULL, &err); qdict = keyval_parse("list.0=null,list.2=eins,list.02=zwei", NULL, &err);