system/qemu
system/qemu
1
0
Fork 0
mirror of https://gitlab.com/qemu-project/qemu synced 2024-07-21 10:24:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

iohandler: switch to GPollFD

Browse source 
Convert iohandler_select_fill() and iohandler_select_poll() to use
GPollFD instead of rfds/wfds/xfds.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Message-id: 1361356113-11049-7-git-send-email-stefanha@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Stefan Hajnoczi 2013-02-20 11:28:29 +01:00 committed by Anthony Liguori
parent 8917c3bdba
commit a3e4b4a809
3 changed files with 34 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
include/qemu/main-loop.h
View file

@ -297,8 +297,8 @@ void qemu_mutex_unlock_iothread(void);
/* internal interfaces */ /* internal interfaces */
void qemu_fd_register(int fd); void qemu_fd_register(int fd);
void qemu_iohandler_fill(int *pnfds, fd_set *readfds, fd_set *writefds, fd_set *xfds); void qemu_iohandler_fill(GArray *pollfds);
void qemu_iohandler_poll(fd_set *readfds, fd_set *writefds, fd_set *xfds, int rc); void qemu_iohandler_poll(GArray *pollfds, int rc);
QEMUBH *qemu_bh_new(QEMUBHFunc *cb, void *opaque); QEMUBH *qemu_bh_new(QEMUBHFunc *cb, void *opaque);
void qemu_bh_schedule_idle(QEMUBH *bh); void qemu_bh_schedule_idle(QEMUBH *bh);

40
iohandler.c
View file

@ -39,6 +39,7 @@ typedef struct IOHandlerRecord {
void *opaque; void *opaque;
QLIST_ENTRY(IOHandlerRecord) next; QLIST_ENTRY(IOHandlerRecord) next;
int fd; int fd;
int pollfds_idx;
bool deleted; bool deleted;
} IOHandlerRecord; } IOHandlerRecord;
@ -78,6 +79,7 @@ int qemu_set_fd_handler2(int fd,
ioh->fd_read = fd_read; ioh->fd_read = fd_read;
ioh->fd_write = fd_write; ioh->fd_write = fd_write;
ioh->opaque = opaque; ioh->opaque = opaque;
ioh->pollfds_idx = -1;
ioh->deleted = 0; ioh->deleted = 0;
qemu_notify_event(); qemu_notify_event();
} }
@ -92,38 +94,56 @@ int qemu_set_fd_handler(int fd,
return qemu_set_fd_handler2(fd, NULL, fd_read, fd_write, opaque); return qemu_set_fd_handler2(fd, NULL, fd_read, fd_write, opaque);
} }
void qemu_iohandler_fill(int *pnfds, fd_set *readfds, fd_set *writefds, fd_set *xfds) void qemu_iohandler_fill(GArray *pollfds)
{ {
IOHandlerRecord *ioh; IOHandlerRecord *ioh;
QLIST_FOREACH(ioh, &io_handlers, next) { QLIST_FOREACH(ioh, &io_handlers, next) {
int events = 0;
if (ioh->deleted) if (ioh->deleted)
continue; continue;
if (ioh->fd_read && if (ioh->fd_read &&
(!ioh->fd_read_poll || (!ioh->fd_read_poll ||
ioh->fd_read_poll(ioh->opaque) != 0)) { ioh->fd_read_poll(ioh->opaque) != 0)) {
FD_SET(ioh->fd, readfds); events |= G_IO_IN | G_IO_HUP | G_IO_ERR;
if (ioh->fd > *pnfds)
*pnfds = ioh->fd;
} }
if (ioh->fd_write) { if (ioh->fd_write) {
FD_SET(ioh->fd, writefds); events |= G_IO_OUT | G_IO_ERR;
if (ioh->fd > *pnfds) }
*pnfds = ioh->fd; if (events) {
GPollFD pfd = {
.fd = ioh->fd,
.events = events,
};
ioh->pollfds_idx = pollfds->len;
g_array_append_val(pollfds, pfd);
} else {
ioh->pollfds_idx = -1;
} }
} }
} }
void qemu_iohandler_poll(fd_set *readfds, fd_set *writefds, fd_set *xfds, int ret) void qemu_iohandler_poll(GArray *pollfds, int ret)
{ {
if (ret > 0) { if (ret > 0) {
IOHandlerRecord *pioh, *ioh; IOHandlerRecord *pioh, *ioh;
QLIST_FOREACH_SAFE(ioh, &io_handlers, next, pioh) { QLIST_FOREACH_SAFE(ioh, &io_handlers, next, pioh) {
if (!ioh->deleted && ioh->fd_read && FD_ISSET(ioh->fd, readfds)) { int revents = 0;
if (!ioh->deleted && ioh->pollfds_idx != -1) {
GPollFD *pfd = &g_array_index(pollfds, GPollFD,
ioh->pollfds_idx);
revents = pfd->revents;
}
if (!ioh->deleted && ioh->fd_read &&
(revents & (G_IO_IN | G_IO_HUP | G_IO_ERR))) {
ioh->fd_read(ioh->opaque); ioh->fd_read(ioh->opaque);
} }
if (!ioh->deleted && ioh->fd_write && FD_ISSET(ioh->fd, writefds)) { if (!ioh->deleted && ioh->fd_write &&
(revents & (G_IO_OUT | G_IO_ERR))) {
ioh->fd_write(ioh->opaque); ioh->fd_write(ioh->opaque);
} }

4
main-loop.c
View file

@ -507,9 +507,9 @@ int main_loop_wait(int nonblocking)
slirp_update_timeout(&timeout); slirp_update_timeout(&timeout);
slirp_pollfds_fill(gpollfds); slirp_pollfds_fill(gpollfds);
#endif #endif
qemu_iohandler_fill(&nfds, &rfds, &wfds, &xfds); qemu_iohandler_fill(gpollfds);
ret = os_host_main_loop_wait(timeout); ret = os_host_main_loop_wait(timeout);
qemu_iohandler_poll(&rfds, &wfds, &xfds, ret); qemu_iohandler_poll(gpollfds, ret);
#ifdef CONFIG_SLIRP #ifdef CONFIG_SLIRP
slirp_pollfds_poll(gpollfds, (ret < 0)); slirp_pollfds_poll(gpollfds, (ret < 0));
#endif #endif