mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 18:05:37 +00:00
rbd: Revert -blockdev parameter password-secret
This reverts a part of commit 8a47e8e
. We're having second thoughts
on the QAPI schema (and thus the external interface), and haven't
reached consensus, yet. Issues include:
* BlockdevOptionsRbd member @password-secret isn't actually a
password, it's a key generated by Ceph.
* We're not sure where member @password-secret belongs (see the
previous commit).
* How @password-secret interacts with settings from a configuration
file specified with @conf is undocumented.
Let's avoid painting ourselves into a corner now, and revert the
feature for 2.9.
Note that users can still configure an authentication key with a
configuration file. They probably do that anyway if they use Ceph
outside QEMU as well.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Message-id: 1490691368-32099-10-git-send-email-armbru@redhat.com
Signed-off-by: Jeff Cody <jcody@redhat.com>
This commit is contained in:
parent
464444fcc1
commit
577d8c9a81
|
@ -2618,9 +2618,6 @@
|
||||||
# @server: Monitor host address and port. This maps
|
# @server: Monitor host address and port. This maps
|
||||||
# to the "mon_host" Ceph option.
|
# to the "mon_host" Ceph option.
|
||||||
#
|
#
|
||||||
# @password-secret: The ID of a QCryptoSecret object providing
|
|
||||||
# the password for the login.
|
|
||||||
#
|
|
||||||
# Since: 2.9
|
# Since: 2.9
|
||||||
##
|
##
|
||||||
{ 'struct': 'BlockdevOptionsRbd',
|
{ 'struct': 'BlockdevOptionsRbd',
|
||||||
|
@ -2629,8 +2626,7 @@
|
||||||
'*conf': 'str',
|
'*conf': 'str',
|
||||||
'*snapshot': 'str',
|
'*snapshot': 'str',
|
||||||
'*user': 'str',
|
'*user': 'str',
|
||||||
'*server': ['InetSocketAddressBase'],
|
'*server': ['InetSocketAddressBase'] } }
|
||||||
'*password-secret': 'str' } }
|
|
||||||
|
|
||||||
##
|
##
|
||||||
# @BlockdevOptionsSheepdog:
|
# @BlockdevOptionsSheepdog:
|
||||||
|
|
Loading…
Reference in a new issue