system/qemu
system/qemu
1
0
Fork 0
mirror of https://gitlab.com/qemu-project/qemu synced 2024-10-07 03:29:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

coreaudio: Always return 0 in handle_voice_change

Browse source 
handle_voice_change() is a CoreAudio callback function as of CoreAudio type
AudioObjectPropertyListenerProc, and for the latter MacOSX.sdk/System/
Library/Frameworks/CoreAudio.framework/Headers/AudioHardware.h
says "The return value is currently unused and should always be 0.".

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220306123410.61063-1-akihiko.odaki@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
This commit is contained in:
Akihiko Odaki 2022-03-06 21:34:10 +09:00 committed by Philippe Mathieu-Daudé
parent 8e30d39bad
commit 44ccb2dbe9
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
audio/coreaudio.c
View file

@ -545,7 +545,6 @@ static OSStatus handle_voice_change(
const AudioObjectPropertyAddress *in_addresses, const AudioObjectPropertyAddress *in_addresses,
void *in_client_data) void *in_client_data)
{ {
OSStatus status;
coreaudioVoiceOut *core = in_client_data; coreaudioVoiceOut *core = in_client_data;
qemu_mutex_lock_iothread(); qemu_mutex_lock_iothread();
@ -554,13 +553,12 @@ static OSStatus handle_voice_change(
fini_out_device(core); fini_out_device(core);
} }
status = init_out_device(core); if (!init_out_device(core)) {
if (!status) {
update_device_playback_state(core); update_device_playback_state(core);
} }
qemu_mutex_unlock_iothread(); qemu_mutex_unlock_iothread();
return status; return 0;
} }
static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as, static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as,