mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-07-21 10:24:33 +00:00
vhost: Fix memory region section comparison
Using memcmp to compare structures wasn't safe,
as I found out on ARM when I was getting falce miscompares.
Use the helper function for comparing the MRSs.
Fixes: ade6d081fc
("vhost: Regenerate region list from changed sections list")
Cc: qemu-stable@nongnu.org
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190814175535.2023-4-dgilbert@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
parent
9366cf02e4
commit
3fc4a64cba
|
@ -451,8 +451,13 @@ static void vhost_commit(MemoryListener *listener)
|
||||||
changed = true;
|
changed = true;
|
||||||
} else {
|
} else {
|
||||||
/* Same size, lets check the contents */
|
/* Same size, lets check the contents */
|
||||||
changed = n_old_sections && memcmp(dev->mem_sections, old_sections,
|
for (int i = 0; i < n_old_sections; i++) {
|
||||||
n_old_sections * sizeof(old_sections[0])) != 0;
|
if (!MemoryRegionSection_eq(&old_sections[i],
|
||||||
|
&dev->mem_sections[i])) {
|
||||||
|
changed = true;
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
trace_vhost_commit(dev->started, changed);
|
trace_vhost_commit(dev->started, changed);
|
||||||
|
|
Loading…
Reference in a new issue