mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 18:05:37 +00:00
qapi-commands: Drop useless initialization
In generated command handlers, the assignment to retval dominates its only use. Therefore, its initialization is useless. Drop it. Suggested-by: Eric Blake <eblake@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
parent
1f9a7a1a58
commit
3f99144cd9
|
@ -742,7 +742,7 @@ Example:
|
|||
static void qmp_marshal_input_my_command(QDict *args, QObject **ret, Error **errp)
|
||||
{
|
||||
Error *local_err = NULL;
|
||||
UserDefOne *retval = NULL;
|
||||
UserDefOne *retval;
|
||||
QmpInputVisitor *mi = qmp_input_visitor_new_strict(QOBJECT(args));
|
||||
QapiDeallocVisitor *md;
|
||||
Visitor *v;
|
||||
|
|
|
@ -205,14 +205,10 @@ def gen_marshal_input(name, args, ret_type, middle_mode):
|
|||
header=hdr)
|
||||
|
||||
if ret_type:
|
||||
if is_c_ptr(ret_type):
|
||||
retval = " %s retval = NULL;" % c_type(ret_type)
|
||||
else:
|
||||
retval = " %s retval;" % c_type(ret_type)
|
||||
ret += mcgen('''
|
||||
%(retval)s
|
||||
%(c_type)s retval;
|
||||
''',
|
||||
retval=retval)
|
||||
c_type=c_type(ret_type))
|
||||
|
||||
if len(args) > 0:
|
||||
ret += gen_visitor_input_containers_decl(args)
|
||||
|
|
Loading…
Reference in a new issue