mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-11-05 20:35:44 +00:00
tracing: only allow -trace to override -D if set
Otherwise any -D settings the user may have made get ignored. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Tested-by: Laurent Vivier <laurent@vivier.eu> Reviewed-by: Robert Foley <robert.foley@linaro.org> Message-Id: <20200225124710.14152-10-alex.bennee@linaro.org>
This commit is contained in:
parent
002375895c
commit
3d88754e2b
1 changed files with 8 additions and 3 deletions
|
@ -226,10 +226,15 @@ void trace_init_file(const char *file)
|
|||
#ifdef CONFIG_TRACE_SIMPLE
|
||||
st_set_trace_file(file);
|
||||
#elif defined CONFIG_TRACE_LOG
|
||||
/* If both the simple and the log backends are enabled, "--trace file"
|
||||
* only applies to the simple backend; use "-D" for the log backend.
|
||||
/*
|
||||
* If both the simple and the log backends are enabled, "--trace file"
|
||||
* only applies to the simple backend; use "-D" for the log
|
||||
* backend. However we should only override -D if we actually have
|
||||
* something to override it with.
|
||||
*/
|
||||
qemu_set_log_filename(file, &error_fatal);
|
||||
if (file) {
|
||||
qemu_set_log_filename(file, &error_fatal);
|
||||
}
|
||||
#else
|
||||
if (file) {
|
||||
fprintf(stderr, "error: --trace file=...: "
|
||||
|
|
Loading…
Reference in a new issue