system/qemu
system/qemu
1
0
Fork 0
mirror of https://gitlab.com/qemu-project/qemu synced 2024-07-20 18:04:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

qmp: Merge ObjectPropertyInfo and DevicePropertyInfo

Browse source 
ObjectPropertyInfo is more generic and only missing @description.
This adds a description to ObjectPropertyInfo and removes
DevicePropertyInfo so the resulting ObjectPropertyInfo can be used
elsewhere.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Message-Id: <20180301130939.15875-2-aik@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Alexey Kardashevskiy 2018-03-02 00:09:38 +11:00 committed by Paolo Bonzini
parent f29d445042
commit 35f63767dc
3 changed files with 18 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
qapi/misc.json
View file

@ -1285,10 +1285,12 @@
# 3) A link type in the form 'link<subtype>' where subtype is a qdev # 3) A link type in the form 'link<subtype>' where subtype is a qdev
# device type name. Link properties form the device model graph. # device type name. Link properties form the device model graph.
# #
# @description: if specified, the description of the property.
#
# Since: 1.2 # Since: 1.2
## ##
{ 'struct': 'ObjectPropertyInfo', { 'struct': 'ObjectPropertyInfo',
'data': { 'name': 'str', 'type': 'str' } } 'data': { 'name': 'str', 'type': 'str', '*description': 'str' } }
## ##
# @qom-list: # @qom-list:
@ -1443,21 +1445,6 @@
'data': { '*implements': 'str', '*abstract': 'bool' }, 'data': { '*implements': 'str', '*abstract': 'bool' },
'returns': [ 'ObjectTypeInfo' ] } 'returns': [ 'ObjectTypeInfo' ] }
##
# @DevicePropertyInfo:
#
# Information about device properties.
#
# @name: the name of the property
# @type: the typename of the property
# @description: if specified, the description of the property.
# (since 2.2)
#
# Since: 1.2
##
{ 'struct': 'DevicePropertyInfo',
'data': { 'name': 'str', 'type': 'str', '*description': 'str' } }
## ##
# @device-list-properties: # @device-list-properties:
# #
@ -1465,13 +1452,13 @@
# #
# @typename: the type name of a device # @typename: the type name of a device
# #
# Returns: a list of DevicePropertyInfo describing a devices properties # Returns: a list of ObjectPropertyInfo describing a devices properties
# #
# Since: 1.2 # Since: 1.2
## ##
{ 'command': 'device-list-properties', { 'command': 'device-list-properties',
'data': { 'typename': 'str'}, 'data': { 'typename': 'str'},
'returns': [ 'DevicePropertyInfo' ] } 'returns': [ 'ObjectPropertyInfo' ] }
## ##
# @xen-set-global-dirty-log: # @xen-set-global-dirty-log:

6
qdev-monitor.c
View file

@ -258,8 +258,8 @@ int qdev_device_help(QemuOpts *opts)
{ {
Error *local_err = NULL; Error *local_err = NULL;
const char *driver; const char *driver;
DevicePropertyInfoList *prop_list; ObjectPropertyInfoList *prop_list;
DevicePropertyInfoList *prop; ObjectPropertyInfoList *prop;
driver = qemu_opt_get(opts, "driver"); driver = qemu_opt_get(opts, "driver");
if (driver && is_help_option(driver)) { if (driver && is_help_option(driver)) {
@ -295,7 +295,7 @@ int qdev_device_help(QemuOpts *opts)
} }
} }
qapi_free_DevicePropertyInfoList(prop_list); qapi_free_ObjectPropertyInfoList(prop_list);
return 1; return 1;
error: error:

20
qmp.c
View file

@ -465,12 +465,12 @@ ObjectTypeInfoList *qmp_qom_list_types(bool has_implements,
* *
* The caller must free the return value. * The caller must free the return value.
*/ */
static DevicePropertyInfo *make_device_property_info(ObjectClass *klass, static ObjectPropertyInfo *make_device_property_info(ObjectClass *klass,
const char *name, const char *name,
const char *default_type, const char *default_type,
const char *description) const char *description)
{ {
DevicePropertyInfo *info; ObjectPropertyInfo *info;
Property *prop; Property *prop;
do { do {
@ -510,14 +510,14 @@ static DevicePropertyInfo *make_device_property_info(ObjectClass *klass,
return info; return info;
} }
DevicePropertyInfoList *qmp_device_list_properties(const char *typename, ObjectPropertyInfoList *qmp_device_list_properties(const char *typename,
Error **errp) Error **errp)
{ {
ObjectClass *klass; ObjectClass *klass;
Object *obj; Object *obj;
ObjectProperty *prop; ObjectProperty *prop;
ObjectPropertyIterator iter; ObjectPropertyIterator iter;
DevicePropertyInfoList *prop_list = NULL; ObjectPropertyInfoList *prop_list = NULL;
klass = object_class_by_name(typename); klass = object_class_by_name(typename);
if (klass == NULL) { if (klass == NULL) {
@ -542,8 +542,8 @@ DevicePropertyInfoList *qmp_device_list_properties(const char *typename,
object_property_iter_init(&iter, obj); object_property_iter_init(&iter, obj);
while ((prop = object_property_iter_next(&iter))) { while ((prop = object_property_iter_next(&iter))) {
DevicePropertyInfo *info; ObjectPropertyInfo *info;
DevicePropertyInfoList *entry; ObjectPropertyInfoList *entry;
/* Skip Object and DeviceState properties */ /* Skip Object and DeviceState properties */
if (strcmp(prop->name, "type") == 0 || if (strcmp(prop->name, "type") == 0 ||