system/qemu
system/qemu
1
0
Fork 0
mirror of https://gitlab.com/qemu-project/qemu synced 2024-10-05 18:49:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

hw/block/pflash_cfi01: Clarify trace events

Browse source 
Use the 'mode_read_array' event when we set the device in such
mode, and use the 'reset' event in DeviceReset handler.

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210310170528.1184868-10-philmd@redhat.com>
This commit is contained in:
Philippe Mathieu-Daudé 2021-03-10 00:31:16 +01:00
parent d910634165
commit 2b49cd652a
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
hw/block/pflash_cfi01.c
View file

@ -663,7 +663,7 @@ static void pflash_write(PFlashCFI01 *pfl, hwaddr offset,
"\n", __func__, offset, pfl->wcycle, pfl->cmd, value); "\n", __func__, offset, pfl->wcycle, pfl->cmd, value);
mode_read_array: mode_read_array:
trace_pflash_reset(); trace_pflash_mode_read_array();
memory_region_rom_device_set_romd(&pfl->mem, true); memory_region_rom_device_set_romd(&pfl->mem, true);
pfl->wcycle = 0; pfl->wcycle = 0;
pfl->cmd = 0x00; /* This model reset value for READ_ARRAY (not CFI) */ pfl->cmd = 0x00; /* This model reset value for READ_ARRAY (not CFI) */
@ -886,6 +886,7 @@ static void pflash_cfi01_system_reset(DeviceState *dev)
{ {
PFlashCFI01 *pfl = PFLASH_CFI01(dev); PFlashCFI01 *pfl = PFLASH_CFI01(dev);
trace_pflash_reset();
/* /*
* The command 0x00 is not assigned by the CFI open standard, * The command 0x00 is not assigned by the CFI open standard,
* but QEMU historically uses it for the READ_ARRAY command (0xff). * but QEMU historically uses it for the READ_ARRAY command (0xff).