system/qemu
system/qemu
1
0
Fork 0
mirror of https://gitlab.com/qemu-project/qemu synced 2024-11-05 20:35:44 +00:00
Code Issues Projects Releases Packages Wiki Activity

hw/scsi/megasas: Simplify using the ldst API

Browse source 
This code is easier to review using the load/store API.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211218111912.1499377-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
This commit is contained in:
Philippe Mathieu-Daudé 2021-12-18 12:19:12 +01:00 committed by Laurent Vivier
parent 6446a79e10
commit 2a0c513669
1 changed files with 3 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
hw/scsi/megasas.c
View file

@ -383,8 +383,7 @@ static int megasas_setup_inquiry(uint8_t *cdb, int pg, int len)
cdb[1] = 0x1; cdb[1] = 0x1;
cdb[2] = pg; cdb[2] = pg;
} }
cdb[3] = (len >> 8) & 0xff; stw_be_p(&cdb[3], len);
cdb[4] = (len & 0xff);
return len; return len;
} }
@ -400,18 +399,8 @@ static void megasas_encode_lba(uint8_t *cdb, uint64_t lba,
} else { } else {
cdb[0] = READ_16; cdb[0] = READ_16;
} }
cdb[2] = (lba >> 56) & 0xff; stq_be_p(&cdb[2], lba);
cdb[3] = (lba >> 48) & 0xff; stl_be_p(&cdb[2 + 8], len);
cdb[4] = (lba >> 40) & 0xff;
cdb[5] = (lba >> 32) & 0xff;
cdb[6] = (lba >> 24) & 0xff;
cdb[7] = (lba >> 16) & 0xff;
cdb[8] = (lba >> 8) & 0xff;
cdb[9] = (lba) & 0xff;
cdb[10] = (len >> 24) & 0xff;
cdb[11] = (len >> 16) & 0xff;
cdb[12] = (len >> 8) & 0xff;
cdb[13] = (len) & 0xff;
} }
/* /*