target/arm: Split out gen_gvec_fn_zzz, do_zzz_fn

Model gen_gvec_fn_zzz on gen_gvec_fn3 in translate-a64.c, but
indicating which kind of register and in which order.

Model do_zzz_fn on the other do_foo functions that take an
argument set and verify sve enabled.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20200815013145.539409-4-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Richard Henderson 2020-08-28 10:02:47 +01:00 committed by Peter Maydell
parent f7d79c41fa
commit 28c4da31be

View file

@ -153,16 +153,13 @@ static void gen_gvec_fn_zz(DisasContext *s, GVecGen2Fn *gvec_fn,
} }
/* Invoke a vector expander on three Zregs. */ /* Invoke a vector expander on three Zregs. */
static bool do_vector3_z(DisasContext *s, GVecGen3Fn *gvec_fn, static void gen_gvec_fn_zzz(DisasContext *s, GVecGen3Fn *gvec_fn,
int esz, int rd, int rn, int rm) int esz, int rd, int rn, int rm)
{ {
if (sve_access_check(s)) { unsigned vsz = vec_full_reg_size(s);
unsigned vsz = vec_full_reg_size(s); gvec_fn(esz, vec_full_reg_offset(s, rd),
gvec_fn(esz, vec_full_reg_offset(s, rd), vec_full_reg_offset(s, rn),
vec_full_reg_offset(s, rn), vec_full_reg_offset(s, rm), vsz, vsz);
vec_full_reg_offset(s, rm), vsz, vsz);
}
return true;
} }
/* Invoke a vector move on two Zregs. */ /* Invoke a vector move on two Zregs. */
@ -274,24 +271,32 @@ const uint64_t pred_esz_masks[4] = {
*** SVE Logical - Unpredicated Group *** SVE Logical - Unpredicated Group
*/ */
static bool do_zzz_fn(DisasContext *s, arg_rrr_esz *a, GVecGen3Fn *gvec_fn)
{
if (sve_access_check(s)) {
gen_gvec_fn_zzz(s, gvec_fn, a->esz, a->rd, a->rn, a->rm);
}
return true;
}
static bool trans_AND_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_AND_zzz(DisasContext *s, arg_rrr_esz *a)
{ {
return do_vector3_z(s, tcg_gen_gvec_and, 0, a->rd, a->rn, a->rm); return do_zzz_fn(s, a, tcg_gen_gvec_and);
} }
static bool trans_ORR_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_ORR_zzz(DisasContext *s, arg_rrr_esz *a)
{ {
return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); return do_zzz_fn(s, a, tcg_gen_gvec_or);
} }
static bool trans_EOR_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_EOR_zzz(DisasContext *s, arg_rrr_esz *a)
{ {
return do_vector3_z(s, tcg_gen_gvec_xor, 0, a->rd, a->rn, a->rm); return do_zzz_fn(s, a, tcg_gen_gvec_xor);
} }
static bool trans_BIC_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_BIC_zzz(DisasContext *s, arg_rrr_esz *a)
{ {
return do_vector3_z(s, tcg_gen_gvec_andc, 0, a->rd, a->rn, a->rm); return do_zzz_fn(s, a, tcg_gen_gvec_andc);
} }
/* /*
@ -300,32 +305,32 @@ static bool trans_BIC_zzz(DisasContext *s, arg_rrr_esz *a)
static bool trans_ADD_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_ADD_zzz(DisasContext *s, arg_rrr_esz *a)
{ {
return do_vector3_z(s, tcg_gen_gvec_add, a->esz, a->rd, a->rn, a->rm); return do_zzz_fn(s, a, tcg_gen_gvec_add);
} }
static bool trans_SUB_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_SUB_zzz(DisasContext *s, arg_rrr_esz *a)
{ {
return do_vector3_z(s, tcg_gen_gvec_sub, a->esz, a->rd, a->rn, a->rm); return do_zzz_fn(s, a, tcg_gen_gvec_sub);
} }
static bool trans_SQADD_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_SQADD_zzz(DisasContext *s, arg_rrr_esz *a)
{ {
return do_vector3_z(s, tcg_gen_gvec_ssadd, a->esz, a->rd, a->rn, a->rm); return do_zzz_fn(s, a, tcg_gen_gvec_ssadd);
} }
static bool trans_SQSUB_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_SQSUB_zzz(DisasContext *s, arg_rrr_esz *a)
{ {
return do_vector3_z(s, tcg_gen_gvec_sssub, a->esz, a->rd, a->rn, a->rm); return do_zzz_fn(s, a, tcg_gen_gvec_sssub);
} }
static bool trans_UQADD_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_UQADD_zzz(DisasContext *s, arg_rrr_esz *a)
{ {
return do_vector3_z(s, tcg_gen_gvec_usadd, a->esz, a->rd, a->rn, a->rm); return do_zzz_fn(s, a, tcg_gen_gvec_usadd);
} }
static bool trans_UQSUB_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_UQSUB_zzz(DisasContext *s, arg_rrr_esz *a)
{ {
return do_vector3_z(s, tcg_gen_gvec_ussub, a->esz, a->rd, a->rn, a->rm); return do_zzz_fn(s, a, tcg_gen_gvec_ussub);
} }
/* /*