mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 09:55:55 +00:00
ui/cocoa.m: Remove unnecessary NSAutoreleasePools
In commit6e657e64cd
in 2013 we added some autorelease pools to deal with complaints from macOS when we made calls into Cocoa from threads that didn't have automatically created autorelease pools. Later on, macOS got stricter about forbidding cross-thread Cocoa calls, and in commit5588840ff7
we restructured the code to avoid them. This left the autorelease pool creation in several functions without any purpose; delete it. We still need the pool in cocoa_refresh() for the clipboard related code which is called directly there. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com> Tested-by: Akihiko Odaki <akihiko.odaki@gmail.com> Message-id: 20220224101330.967429-3-peter.maydell@linaro.org
This commit is contained in:
parent
8d65dee2c4
commit
268c11984e
|
@ -1976,8 +1976,6 @@ int main (int argc, char **argv) {
|
|||
static void cocoa_update(DisplayChangeListener *dcl,
|
||||
int x, int y, int w, int h)
|
||||
{
|
||||
NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init];
|
||||
|
||||
COCOA_DEBUG("qemu_cocoa: cocoa_update\n");
|
||||
|
||||
dispatch_async(dispatch_get_main_queue(), ^{
|
||||
|
@ -1993,14 +1991,11 @@ static void cocoa_update(DisplayChangeListener *dcl,
|
|||
}
|
||||
[cocoaView setNeedsDisplayInRect:rect];
|
||||
});
|
||||
|
||||
[pool release];
|
||||
}
|
||||
|
||||
static void cocoa_switch(DisplayChangeListener *dcl,
|
||||
DisplaySurface *surface)
|
||||
{
|
||||
NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init];
|
||||
pixman_image_t *image = surface->image;
|
||||
|
||||
COCOA_DEBUG("qemu_cocoa: cocoa_switch\n");
|
||||
|
@ -2015,7 +2010,6 @@ static void cocoa_switch(DisplayChangeListener *dcl,
|
|||
[cocoaView updateUIInfo];
|
||||
[cocoaView switchSurface:image];
|
||||
});
|
||||
[pool release];
|
||||
}
|
||||
|
||||
static void cocoa_refresh(DisplayChangeListener *dcl)
|
||||
|
|
Loading…
Reference in a new issue