mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 01:43:39 +00:00
opts: remove redundant check for NULL parameter
No callers of get_opt_value() pass in a NULL for the "value" parameter, so the check is redundant. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Message-Id: <20180514171913.17664-4-berrange@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Tested-by: Roman Kagan <rkagan@virtuozzo.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
parent
f8da93a0ff
commit
0c2f6e7ee9
|
@ -75,20 +75,16 @@ const char *get_opt_value(const char *p, char **value)
|
|||
size_t capacity = 0, length;
|
||||
const char *offset;
|
||||
|
||||
if (value) {
|
||||
*value = NULL;
|
||||
}
|
||||
*value = NULL;
|
||||
while (1) {
|
||||
offset = qemu_strchrnul(p, ',');
|
||||
length = offset - p;
|
||||
if (*offset != '\0' && *(offset + 1) == ',') {
|
||||
length++;
|
||||
}
|
||||
if (value) {
|
||||
*value = g_renew(char, *value, capacity + length + 1);
|
||||
strncpy(*value + capacity, p, length);
|
||||
(*value)[capacity + length] = '\0';
|
||||
}
|
||||
*value = g_renew(char, *value, capacity + length + 1);
|
||||
strncpy(*value + capacity, p, length);
|
||||
(*value)[capacity + length] = '\0';
|
||||
capacity += length;
|
||||
if (*offset == '\0' ||
|
||||
*(offset + 1) != ',') {
|
||||
|
|
Loading…
Reference in a new issue