iothread: generalize iothread_set_param/iothread_get_param

Changes in preparation for next patches where we add a new
parameter not related to the poll mechanism.

Let's add two new generic functions (iothread_set_param and
iothread_get_param) that we use to set and get IOThread
parameters.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Message-id: 20210721094211.69853-2-sgarzare@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Stefano Garzarella 2021-07-21 11:42:09 +02:00 committed by Stefan Hajnoczi
parent 801f3db756
commit 0445409d74

View file

@ -213,7 +213,7 @@ static PollParamInfo poll_shrink_info = {
"poll-shrink", offsetof(IOThread, poll_shrink), "poll-shrink", offsetof(IOThread, poll_shrink),
}; };
static void iothread_get_poll_param(Object *obj, Visitor *v, static void iothread_get_param(Object *obj, Visitor *v,
const char *name, void *opaque, Error **errp) const char *name, void *opaque, Error **errp)
{ {
IOThread *iothread = IOTHREAD(obj); IOThread *iothread = IOTHREAD(obj);
@ -223,7 +223,7 @@ static void iothread_get_poll_param(Object *obj, Visitor *v,
visit_type_int64(v, name, field, errp); visit_type_int64(v, name, field, errp);
} }
static void iothread_set_poll_param(Object *obj, Visitor *v, static bool iothread_set_param(Object *obj, Visitor *v,
const char *name, void *opaque, Error **errp) const char *name, void *opaque, Error **errp)
{ {
IOThread *iothread = IOTHREAD(obj); IOThread *iothread = IOTHREAD(obj);
@ -232,17 +232,36 @@ static void iothread_set_poll_param(Object *obj, Visitor *v,
int64_t value; int64_t value;
if (!visit_type_int64(v, name, &value, errp)) { if (!visit_type_int64(v, name, &value, errp)) {
return; return false;
} }
if (value < 0) { if (value < 0) {
error_setg(errp, "%s value must be in range [0, %" PRId64 "]", error_setg(errp, "%s value must be in range [0, %" PRId64 "]",
info->name, INT64_MAX); info->name, INT64_MAX);
return; return false;
} }
*field = value; *field = value;
return true;
}
static void iothread_get_poll_param(Object *obj, Visitor *v,
const char *name, void *opaque, Error **errp)
{
iothread_get_param(obj, v, name, opaque, errp);
}
static void iothread_set_poll_param(Object *obj, Visitor *v,
const char *name, void *opaque, Error **errp)
{
IOThread *iothread = IOTHREAD(obj);
if (!iothread_set_param(obj, v, name, opaque, errp)) {
return;
}
if (iothread->ctx) { if (iothread->ctx) {
aio_context_set_poll_params(iothread->ctx, aio_context_set_poll_params(iothread->ctx,
iothread->poll_max_ns, iothread->poll_max_ns,