Wim Taymans
f562b16706
alsa-plugin: use log topics
2021-10-03 08:17:43 +02:00
Wim Taymans
3348fd9885
alsa-plugin: make sure we don't deref NULL
...
Also fixes a warning.
2021-10-01 15:33:51 +02:00
Jonas Holmberg
61a2577941
pipewire-alsa: fix a memory leak
...
Free node_name.
2021-09-27 11:05:34 +02:00
Wim Taymans
423e8b2f03
Revert "pipewire-alsa: Make it MT safe"
...
This reverts commit f22dd9d781
.
Obsolete now that pw_init and factory loading/unloading has been
made thread safe.
2021-09-21 12:35:03 +02:00
Wim Taymans
64f83158f4
alsa-plugin: improve error handling and recovery
...
Ignore -ENOENT errors, they are likely because some device was
removed.
Make sure we clear the poll descriptor when nothing is pollable, even
in the error case.
Clear the error after we reported it instead of reporting it forever.
Fixes #1627
2021-09-20 15:48:04 +02:00
Wim Taymans
f6f10669a0
alsa: destroy stream first and then context
...
This makes things more deterministic.
2021-09-15 20:57:10 +02:00
Jonas Holmberg
f22dd9d781
pipewire-alsa: Make it MT safe
...
Make pipewire-alsa MT safe so that multi threaded programs can use it
without any extra locks.
2021-09-08 16:36:58 +02:00
Wim Taymans
7846687df8
alsa: suggest rate to graph with node.rate
2021-08-18 09:56:20 +02:00
Wim Taymans
780f2d645d
alsa: enable client-rt for alsa clients
...
So that the pipewire thread is running with RT priority.
2021-08-09 15:28:00 +02:00
Wim Taymans
d88e8edd11
avoid shadowing arguments
2021-07-06 17:55:16 +02:00
Wim Taymans
91f4e4d3c8
alsa: catch and handle some more errors
2021-07-06 17:54:08 +02:00
George Kiagiadakis
df8bd85277
alsa-ctl: filter for and use only the "default" metadata object
...
Fixes #1384
2021-07-02 17:44:35 +03:00
Barnabás Pőcze
f5d51162c4
treewide: mark things static
and const
...
Mark some structures, arrays static/const at various places.
In some cases this prevents unnecessary initialization
when a function is entered.
All in all, the text segments across all shared
libraries are reduced by about 2 KiB. However,
the total size increases by about 2 KiB as well.
2021-06-30 14:44:08 +02:00
George Kiagiadakis
5ee9133b60
alsa plugin: allow specifying a media.role on the virtual device name
...
So that we can do:
aplay -D pipewire:ROLE=Music music.wav
aplay -D pipewire:ROLE=Notification notice.wav
2021-06-22 14:48:31 +00:00
George Kiagiadakis
59407d2f08
includes: update all references to extensions to point to pipewire/extensions
...
This also brings the advantage that all tools, examples, modules, components
can also be compiled standalone out-of-tree using libpipewire from the system
2021-06-18 17:54:18 +03:00
Peter Hutterer
da339c286f
meson.build: drop HAVE_CONFIG_H
...
This is an autotools leftover, with meson we're always guaranteed to have
the config.h file.
2021-06-10 09:04:16 +10:00
Peter Hutterer
0054319d88
meson.build: add -D_GNU_SOURCE to the project arguments
...
This appends it to every compilation command so we can get rid of the c_args
for (almost all) executables.
2021-06-09 07:47:51 +00:00
Peter Hutterer
e0471c6757
pipewire: allow NULL pointers in pw_properties_free()
...
Just like the real free() we should just ignore a NULL pointer, makes the
caller code easier for those instances where properties are optional.
Patch generated with concinelle with a few manual fixes.
2021-06-02 10:56:46 +00:00
Wim Taymans
5a186ece01
alsa: handle plugin errors better
...
When the plugins can't be loaded, we fail to make a main_loop.
Handle this case instead of segfaulting.
See #1239
2021-05-28 11:38:02 +02:00
Peter Hutterer
f3f915e897
pipewire-alsa: fix scan-build errors for unused variables
...
All cases of value stored but never read
2021-05-26 07:51:27 +00:00
Peter Hutterer
522f87d5ea
treewide: replace strcmp() != 0 with !spa_streq
...
This change is only done in source files for now, header files will be done
separately.
2021-05-18 22:10:27 +10:00
Peter Hutterer
95a84e797a
treewide: replace !strcmp() with spa_streq()
...
This change is only done in source files for now, header files will be done
separately.
2021-05-18 22:10:27 +10:00
Peter Hutterer
7697ed0757
treewide: replace strcmp() == 0 with spa_streq()
...
This change is only done in source files for now, header files will be done
separately.
2021-05-18 22:10:27 +10:00
Wim Taymans
0999f3cf93
alsa-plugin: handle context create error
2021-05-10 13:28:36 +02:00
Peter Hutterer
2405f0942b
spa/buffer: rename SPA_MEMBER to SPA_PTROFF
...
SPA_MEMBER is misleading, all we're doing here is pointer+offset and a
type-casting the result. Rename to SPA_PTROFF which is more expressive (and
has the same number of characters so we don't need to re-indent).
2021-05-06 09:39:39 +00:00
Peter Hutterer
223f20709d
meson: replace join_paths(a, b) with a / b
...
More readable and from the meson reference manual:
(since 0.49.0) Using the/ operator on strings is equivalent to calling join_paths.
2021-04-15 06:57:00 +00:00
Wim Taymans
877309bfbe
use priority.session to select the default sink/source
...
priority.session is meant to be used to set routing priorities.
priority.driver is meant to be used by the scheduler to select what
nodes is best for driving the graph. This usually depends on the
hardware quality and the use case (Pro Audio devices are likely
to be used as driving the graph).
See #1028
2021-04-08 17:48:13 +02:00
Wim Taymans
f314119aa9
alsa-plugin: add some checks to avoid using invalid values
2021-03-27 20:44:21 +01:00
Wim Taymans
c8fd34a41d
metadata: store default-nodes as JSON
...
Don't just store the id in the metadata but a JSON object with
the node name. This makes it possible to easily introspect the
metadata and also extend the metadata with more fields later.
Instead of matching the metadata id to the global ids we now
have to match it against the name.
2021-03-05 17:37:12 +01:00
Wim Taymans
184bdbeb4c
alsa-plugin: Implement query_chmaps again
...
Return a list of our supported channel positions.
Fixes #825
2021-03-04 11:56:28 +01:00
Jonas Holmberg
29be757598
pipewire-alsa: fix drain for capture
...
Since pw_stream doesn't call the drained callback after flush for
capture it has to be called explicitly from process.
2021-03-03 19:00:13 +00:00
Wim Taymans
0aadc0450d
alsa: implement poll_descriptors
...
In there we can evaluate the poll fd and make sure it blocks or not
in the following poll based on the buffer filled levels. Some API
is very sensitive about this, it seems.
Fixes #433
2021-03-02 15:03:27 +01:00
Wim Taymans
8386ddff78
alsa-plugin: Fix default channel layout
...
We need to use the default channel layout that alsa clients expect.
Remove query chmap, nobody uses that, we need to use the alsa default
channel map.
Implement set_chmap in case anybody wants to set a custom map.
2021-02-25 17:42:32 +01:00
Wim Taymans
555d5db384
alsa: make sure we are started when draining
...
We need to be started before waiting for drain.
Fixes #787
2021-02-25 12:14:42 +01:00
Wim Taymans
b9241b1d73
alsa: set application.name
2021-02-19 10:06:40 +01:00
Wim Taymans
7053936ffd
don't attempt to connect to empty remote name
...
Fixes jconvolver startup.
See #744
2021-02-18 10:22:39 +01:00
Wim Taymans
972e740519
Don't advertize formats we don't yet support
...
We don't handle the reverse endian formats yet so make sure we
don't advertize them.
2021-02-05 12:12:44 +01:00
Wim Taymans
32a3913933
alsa-plugin: use MIN_BUFFERS for max as well
...
To get a more reasonable max
2021-02-04 17:15:46 +01:00
thedannysmith
5e9246e1f7
alsa-plugin: change hw-constrainy buffer-size
2021-02-04 17:14:19 +01:00
Wim Taymans
62cf8c6130
alsa-plugin: improve client name
2021-02-04 12:52:23 +01:00
Wim Taymans
675a12ef33
alsa: clamp elapsed time to delay
...
If the elapsed time is larger than the delay, we are dealing with
an older timestamp.
Fixes #597
2021-01-20 11:54:19 +01:00
Wim Taymans
fd520c4b39
alsa-plugin: set buffer size correctly
...
Our output buffer size is always what is needed to produce one
period of samples. We use nframes from the hardware and the rest
we fill with silence.
2021-01-18 10:03:19 +01:00
Wim Taymans
d2aee61880
alsa: don't write more than wat is requested
2021-01-17 17:20:59 +01:00
Wim Taymans
b4e3d546e0
alsa: fill frames with silence when underrun
...
Keep track of how many samples we need to produce. If we don't have
enough samples in the ringbuffer, fill the rest with silence.
See #564
2021-01-15 18:34:38 +01:00
Wim Taymans
5817b66a20
alsa-plugin: only parse props when updated
...
Check if the properties got update before we try to parse them.
If they are not updated, they might be empty and we would lose
our previously parse values.
Fixes default volume in alsa-mixer.
2021-01-15 10:29:32 +01:00
Wim Taymans
0c2b4df8e5
alsa: implement _delay to get smoother timestamps
...
Fixes #536
2021-01-09 10:50:39 +01:00
Wim Taymans
3f0cadfa00
alsa: use rate_match to read exactly what we need
...
Use the rate match from the resampler to get the exact amount
of samples we need to provide in this cycle.
2021-01-08 16:55:24 +01:00
Wim Taymans
55c5e48578
alsa: set offset to 0 for playback streams
2020-12-18 15:32:27 +01:00
Wim Taymans
b8300c663b
improve some errors
...
Silence some -ENOENT warnings, they can happen when the object we
are introspecting is destroyed
2020-11-29 16:22:50 +01:00
Elliott Sales de Andrade
0a30eb6329
Fix a possible uninitialized variable.
...
Also, change the type to more accurately reflect its usage.
2020-11-23 15:36:08 +00:00