system/pipewire
system/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire synced 2024-07-21 02:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

impl-node: don't report xrun when pending <= 0

Browse source 
We might decrement too much but that would mean the driver was triggered
at some point and we don't really have an error.

Improve some debug
This commit is contained in:
Wim Taymans 2024-04-04 21:12:43 +02:00
parent 4db96d2197
commit 9cb4d820d5
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/pipewire/impl-node.c
View file

@ -1282,8 +1282,9 @@ static inline int process_node(void *data)
uint64_t nsec;
nsec = get_time_ns(data_system);
pw_log_trace_fp("%p: %s process remote:%u exported:%u %"PRIu64,
this, this->name, this->remote, this->exported, nsec);
pw_log_trace_fp("%p: %s process remote:%u exported:%u %"PRIu64" %"PRIu64,
this, this->name, this->remote, this->exported,
a->signal_time, nsec);
a->status = PW_NODE_ACTIVATION_AWAKE;
a->awake_time = nsec;
@ -1846,7 +1847,7 @@ static int node_ready(void *data, int status)
uint64_t min_timeout = UINT64_MAX;
int32_t pending;
if (SPA_UNLIKELY((pending = pw_node_activation_state_xchg(state)) != 0)) {
if (SPA_UNLIKELY((pending = pw_node_activation_state_xchg(state)) > 0)) {
pw_log_debug("(%s-%u) graph not finished: state:%p quantum:%"PRIu64
" pending %d/%d", node->name, node->info.id,
state, a->position.clock.duration,

2
src/pipewire/impl-node.h
View file

@ -88,7 +88,7 @@ struct pw_impl_node_rt_events {
void (*complete) (void *data);
/** the driver node did not complete processing */
void (*incomplete) (void *data);
/** the node had */
/** the node had a timeout */
void (*timeout) (void *data);
};