test: add a test for the logger truncation

See c851349f17

test/meson.build

@@ -57,6 +57,13 @@ test('test context',
                include_directories: pwtest_inc,
                link_with: pwtest_lib)
 )
+test('test support',
+    executable('test-support',
+               'test-support.c',
+               'test-logger.c',
+               include_directories: pwtest_inc,
+               link_with: pwtest_lib)
+)
 test('test spa',
     executable('test-spa',
                'test-spa-buffer.c',

test/test-logger.c

@@ -0,0 +1,83 @@
+/* PipeWire
+ *
+ * Copyright © 2021 Red Hat, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#include "pwtest.h"
+
+#include <unistd.h>
+
+#include <spa/utils/names.h>
+#include <spa/support/plugin.h>
+#include <spa/support/log.h>
+#include <pipewire/pipewire.h>
+
+PWTEST(logger_truncate_long_lines)
+{
+	struct pwtest_spa_plugin *plugin;
+	void *iface;
+	char fname[PATH_MAX];
+	struct spa_dict_item item;
+	struct spa_dict info;
+	char buffer[1024];
+	FILE *fp;
+	bool mark_line_found = false;
+
+	pw_init(0, NULL);
+
+	pwtest_mkstemp(fname);
+	item = SPA_DICT_ITEM_INIT(SPA_KEY_LOG_FILE, fname);
+	info = SPA_DICT_INIT(&item, 1);
+	plugin = pwtest_spa_plugin_new();
+	iface = pwtest_spa_plugin_load_interface(plugin, "support/libspa-support",
+						 SPA_NAME_SUPPORT_LOG, SPA_TYPE_INTERFACE_Log,
+						 &info);
+	pwtest_ptr_notnull(iface);
+
+	/* Print a line expected to be truncated */
+	spa_log_error(iface, "MARK: %1100s", "foo");
+
+	fp = fopen(fname, "r");
+	while (fgets(buffer, sizeof(buffer), fp) != NULL) {
+		if (strstr(buffer, "MARK:")) {
+			const char *suffix = ".. (truncated)\n";
+			int len = strlen(buffer);
+			pwtest_str_eq(buffer + len - strlen(suffix), suffix);
+			mark_line_found = true;
+			break;
+		}
+	}
+
+	fclose(fp);
+
+	pwtest_bool_true(mark_line_found);
+	pwtest_spa_plugin_destroy(plugin);
+
+	return PWTEST_PASS;
+}
+
+PWTEST_SUITE(logger)
+{
+	pwtest_add(logger_truncate_long_lines, PWTEST_NOARG);
+
+	return PWTEST_PASS;
+}

test/test-support.c

@@ -0,0 +1,88 @@
+/* PipeWire
+ *
+ * Copyright © 2021 Red Hat, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#include "pwtest.h"
+
+#include <spa/utils/names.h>
+#include <spa/support/plugin.h>
+#include <spa/support/log.h>
+
+PWTEST(pwtest_load_nonexisting)
+{
+	struct pwtest_spa_plugin *plugin;
+	void *iface;
+
+	plugin = pwtest_spa_plugin_new();
+
+	pwtest_neg_errno_check(
+		pwtest_spa_plugin_try_load_interface(plugin, &iface,
+					"support/does_not_exist",
+					SPA_NAME_SUPPORT_LOG, SPA_TYPE_INTERFACE_Log,
+					NULL),
+		-ENOENT);
+
+	pwtest_neg_errno_check(
+		pwtest_spa_plugin_try_load_interface(plugin, &iface,
+					"support/libspa-support",
+					"foo.bar", SPA_TYPE_INTERFACE_Log,
+					NULL),
+		-EINVAL);
+
+	pwtest_neg_errno_check(
+		pwtest_spa_plugin_try_load_interface(plugin, &iface,
+					"support/libspa-support",
+					SPA_NAME_SUPPORT_LOG,
+					"foo", NULL),
+		-ENOSYS);
+
+	pwtest_spa_plugin_destroy(plugin);
+
+	return PWTEST_PASS;
+}
+
+PWTEST(pwtest_load_plugin)
+{
+	struct pwtest_spa_plugin *plugin;
+	void *iface;
+
+	plugin = pwtest_spa_plugin_new();
+
+	pwtest_neg_errno_ok(
+		pwtest_spa_plugin_try_load_interface(plugin, &iface,
+					"support/libspa-support",
+					SPA_NAME_SUPPORT_LOG, SPA_TYPE_INTERFACE_Log,
+					NULL)
+		);
+
+	pwtest_spa_plugin_destroy(plugin);
+	return PWTEST_PASS;
+}
+
+PWTEST_SUITE(support)
+{
+	pwtest_add(pwtest_load_nonexisting, PWTEST_NOARG);
+	pwtest_add(pwtest_load_plugin, PWTEST_NOARG);
+
+	return PWTEST_PASS;
+}