spa: don't warn for NULL io

The io is set to NULL when the port becomes unnegotiated.
This commit is contained in:
Wim Taymans 2022-09-01 15:31:14 +02:00
parent f48f158566
commit 2fa1b4384b
15 changed files with 30 additions and 33 deletions

View file

@ -753,8 +753,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
io = this->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = this->io) == NULL)
return -EIO;
spa_log_trace_fp(this->log, "%p; status %d", this, io->status);

View file

@ -749,9 +749,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
port = GET_OUT_PORT(this, 0);
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
spa_log_trace_fp(this->log, NAME " %p: status %d", this, io->status);

View file

@ -931,7 +931,8 @@ static int impl_node_process(void *object)
port = &this->port;
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
if (port->io_control)
process_control(this, &port->io_control->sequence);

View file

@ -705,9 +705,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
port = GET_PORT(this, SPA_DIRECTION_OUTPUT, 0);
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
spa_log_trace_fp(this->log, "%p: process %d %d/%d %d", this, io->status,
io->buffer_id, port->n_buffers, this->following);

View file

@ -1461,8 +1461,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
port = &this->port;
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
if (this->position && this->position->clock.flags & SPA_IO_CLOCK_FLAG_FREEWHEEL) {
io->status = SPA_STATUS_NEED_DATA;

View file

@ -1345,8 +1345,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
port = &this->port;
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
spa_log_trace(this->log, "%p status:%d", this, io->status);

View file

@ -1147,8 +1147,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
port = &this->port;
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
if (io->status == SPA_STATUS_HAVE_DATA && io->buffer_id < port->n_buffers) {
struct buffer *b = &port->buffers[io->buffer_id];

View file

@ -1295,8 +1295,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
port = &this->port;
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
/* Return if we already have a buffer */
if (io->status == SPA_STATUS_HAVE_DATA)

View file

@ -823,8 +823,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(impl != NULL, -EINVAL);
port = GET_OUT_PORT(impl, 0);
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
if (port->control)
process_control(impl, &port->control->sequence);

View file

@ -737,9 +737,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
port = &this->port;
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
if (io->status != SPA_STATUS_HAVE_DATA)
return io->status;

View file

@ -639,9 +639,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
port = &this->port;
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
if (io->status == SPA_STATUS_HAVE_DATA && io->buffer_id < port->n_buffers) {
struct buffer *b = &port->buffers[io->buffer_id];

View file

@ -680,8 +680,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
port = &this->port;
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
if (io->status == SPA_STATUS_HAVE_DATA)
return SPA_STATUS_HAVE_DATA;

View file

@ -879,8 +879,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
port = GET_OUT_PORT(this, 0);
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
if (port->control)
process_control(this, &port->control->sequence);

View file

@ -787,8 +787,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
port = &this->port;
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
if (io->status == SPA_STATUS_HAVE_DATA)
return SPA_STATUS_HAVE_DATA;

View file

@ -802,8 +802,8 @@ static int impl_node_process(void *object)
spa_return_val_if_fail(this != NULL, -EINVAL);
port = &this->port;
io = port->io;
spa_return_val_if_fail(io != NULL, -EIO);
if ((io = port->io) == NULL)
return -EIO;
if (io->status == SPA_STATUS_HAVE_DATA)
return SPA_STATUS_HAVE_DATA;