mirror of
https://github.com/torvalds/linux
synced 2024-11-05 18:23:50 +00:00
bb617ee3f8
When reading through sound/pci/cs46xx/dsp_spos.c I noticed a couple of things in cs46xx_dsp_spos_create(). It seems to me that we don't always free the various memory buffers we allocate and we also do some work (structure member assignment) early, that is completely pointless if some of the memory allocations fail and we end up just aborting the whole thing. I don't have hardware to test, so the patch below is compile tested only, but it makes the following changes: - Make sure we always free all allocated memory on failures. - Don't do pointless work assigning to structure members before we know all memory allocations, that may abort progress, have completed successfully. - Remove some trailing whitespace. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Tested-by: Ondrej Zary <linux@rainbow-software.org> Signed-off-by: Takashi Iwai <tiwai@suse.de> |
||
|---|---|---|
| .. | ||
| imgs | ||
| cs46xx.c | ||
| cs46xx_image.h | ||
| cs46xx_lib.c | ||
| cs46xx_lib.h | ||
| dsp_spos.c | ||
| dsp_spos.h | ||
| dsp_spos_scb_lib.c | ||
| Makefile | ||