system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-19 09:49:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
linux/drivers/scsi/qla2xxx
History
Arnd Bergmann fab683eb12 scsi: qla2xxxx: avoid type mismatch in comparison 
A recent bug fix added code that does

        bool logged_out = (status & 0xFFFF);
        if (logged_out == CTIO_PORT_LOGGED_OUT)
		...

This looks wrong because we are comparing a boolean with an
integer constant, ang gcc warns about it accordingly:

drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_do_ctio_completion':
drivers/scsi/qla2xxx/qla_target.c:3587:20: warning: comparison of constant '41' with boolean expression is always false [-Wbool-compare]
        (logged_out == CTIO_PORT_LOGGED_OUT) ?

The correct fix is presumably to make that variable an 'int'.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 71cdc07964 ("qla2xxx: Delete session if initiator is gone from FW")
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
2016-01-20 03:03:24 -08:00
..
Kconfig qla2xxx: Update tcm_qla2xxx module description to 24xx+ 2015-08-02 22:41:14 -07:00
Makefile [SCSI] qla2xxx: Add support for ISP2071. 2014-03-15 10:18:50 -07:00
qla_attr.c qla2xxx: Added interface to send explicit LOGO. 2016-01-07 13:57:43 -08:00
qla_bsg.c qla2xxx: Remove set-but-not-used variables 2015-08-26 10:34:49 -07:00
qla_bsg.h qla2xxx: Change copyright year to 2014 in all the source files. 2014-05-19 13:31:02 +02:00
qla_dbg.c qla2xxx: Wait for all conflicts before ack'ing PLOGI 2016-01-07 13:57:44 -08:00
qla_dbg.h qla2xxx: Change copyright year to 2014 in all the source files. 2014-05-19 13:31:02 +02:00
qla_def.h qla2xxx: Set all queues to 4k 2016-01-07 13:57:49 -08:00
qla_devtbl.h
qla_dfs.c qla2xxx: Add FW resource count in DebugFS. 2016-01-07 13:57:42 -08:00
qla_fw.h qla2xxx: Honor FCP_RSP retry delay timer field. 2014-09-25 14:25:04 +02:00
qla_gbl.h qla2xxx: Move atioq to a different lock to reduce lock contention 2016-01-07 13:57:48 -08:00
qla_gs.c qla2xxx: Remove __constant_ prefix 2015-08-26 10:40:32 -07:00
qla_init.c qla2xxx: Check for online flag instead of active reset when transmitting responses 2016-01-07 13:57:50 -08:00
qla_inline.h qla2xxx: Added interface to send explicit LOGO. 2016-01-07 13:57:43 -08:00
qla_iocb.c qla2xxx: Added interface to send explicit LOGO. 2016-01-07 13:57:43 -08:00
qla_isr.c qla2xxx: Move atioq to a different lock to reduce lock contention 2016-01-07 13:57:48 -08:00
qla_mbx.c qla2xxx: Add FW resource count in DebugFS. 2016-01-07 13:57:42 -08:00
qla_mid.c qla2xxx: Remove set-but-not-used variables 2015-08-26 10:34:49 -07:00
qla_mr.c qla2xxx: Fix sparse annotations 2015-08-26 10:42:25 -07:00
qla_mr.h qla2xxx: Adjust adapter reset routine to the changes in firmware specification for ISPFx00. 2014-05-19 13:31:03 +02:00
qla_nx.c qla2xxx: Avoid that sparse complains about context imbalances 2015-08-26 10:46:04 -07:00
qla_nx.h qla2xxx: Change copyright year to 2014 in all the source files. 2014-05-19 13:31:02 +02:00
qla_nx2.c qla2xxx: Replace two macros with an inline function 2015-08-26 10:35:35 -07:00
qla_nx2.h qla2xxx: Replace two macros with an inline function 2015-08-26 10:35:35 -07:00
qla_os.c qla2xxx: Set all queues to 4k 2016-01-07 13:57:49 -08:00
qla_settings.h qla2xxx: Change copyright year to 2014 in all the source files. 2014-05-19 13:31:02 +02:00
qla_sup.c SCSI misc on 20150901 2015-09-02 12:22:54 -07:00
qla_target.c scsi: qla2xxxx: avoid type mismatch in comparison 2016-01-20 03:03:24 -08:00
qla_target.h qla2xxx: Move atioq to a different lock to reduce lock contention 2016-01-07 13:57:48 -08:00
qla_tmpl.c qla2xxx: Avoid that sparse complains about context imbalances 2015-08-26 10:46:04 -07:00
qla_tmpl.h qla2xxx: ISP27xx fwdump template error print simplification. 2014-09-25 14:25:02 +02:00
qla_version.h qla2xxx: Update driver version to 8.07.00.26-k 2015-08-26 17:51:01 -07:00
tcm_qla2xxx.c qla2xxx: Add selective command queuing 2016-01-07 13:57:47 -08:00
tcm_qla2xxx.h target: move transport ID handling to the core 2015-05-30 22:42:30 -07:00