mirror of
https://github.com/torvalds/linux
synced 2024-07-22 11:10:46 +00:00
abc76cf552
If there's no OCB state, don't ask the driver/mac80211 to leave, since that's just confusing. Since set/clear the chandef state, that's a simple check. Reported-by: syzbot+09d1cd2f71e6dd3bfd2c@syzkaller.appspotmail.com Signed-off-by: Johannes Berg <johannes.berg@intel.com>
93 lines
1.9 KiB
C
93 lines
1.9 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* OCB mode implementation
|
|
*
|
|
* Copyright: (c) 2014 Czech Technical University in Prague
|
|
* (c) 2014 Volkswagen Group Research
|
|
* Copyright (C) 2022 Intel Corporation
|
|
* Author: Rostislav Lisovy <rostislav.lisovy@fel.cvut.cz>
|
|
* Funded by: Volkswagen Group Research
|
|
*/
|
|
|
|
#include <linux/ieee80211.h>
|
|
#include <net/cfg80211.h>
|
|
#include "nl80211.h"
|
|
#include "core.h"
|
|
#include "rdev-ops.h"
|
|
|
|
int __cfg80211_join_ocb(struct cfg80211_registered_device *rdev,
|
|
struct net_device *dev,
|
|
struct ocb_setup *setup)
|
|
{
|
|
struct wireless_dev *wdev = dev->ieee80211_ptr;
|
|
int err;
|
|
|
|
ASSERT_WDEV_LOCK(wdev);
|
|
|
|
if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_OCB)
|
|
return -EOPNOTSUPP;
|
|
|
|
if (!rdev->ops->join_ocb)
|
|
return -EOPNOTSUPP;
|
|
|
|
if (WARN_ON(!setup->chandef.chan))
|
|
return -EINVAL;
|
|
|
|
err = rdev_join_ocb(rdev, dev, setup);
|
|
if (!err)
|
|
wdev->u.ocb.chandef = setup->chandef;
|
|
|
|
return err;
|
|
}
|
|
|
|
int cfg80211_join_ocb(struct cfg80211_registered_device *rdev,
|
|
struct net_device *dev,
|
|
struct ocb_setup *setup)
|
|
{
|
|
struct wireless_dev *wdev = dev->ieee80211_ptr;
|
|
int err;
|
|
|
|
wdev_lock(wdev);
|
|
err = __cfg80211_join_ocb(rdev, dev, setup);
|
|
wdev_unlock(wdev);
|
|
|
|
return err;
|
|
}
|
|
|
|
int __cfg80211_leave_ocb(struct cfg80211_registered_device *rdev,
|
|
struct net_device *dev)
|
|
{
|
|
struct wireless_dev *wdev = dev->ieee80211_ptr;
|
|
int err;
|
|
|
|
ASSERT_WDEV_LOCK(wdev);
|
|
|
|
if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_OCB)
|
|
return -EOPNOTSUPP;
|
|
|
|
if (!rdev->ops->leave_ocb)
|
|
return -EOPNOTSUPP;
|
|
|
|
if (!wdev->u.ocb.chandef.chan)
|
|
return -ENOTCONN;
|
|
|
|
err = rdev_leave_ocb(rdev, dev);
|
|
if (!err)
|
|
memset(&wdev->u.ocb.chandef, 0, sizeof(wdev->u.ocb.chandef));
|
|
|
|
return err;
|
|
}
|
|
|
|
int cfg80211_leave_ocb(struct cfg80211_registered_device *rdev,
|
|
struct net_device *dev)
|
|
{
|
|
struct wireless_dev *wdev = dev->ieee80211_ptr;
|
|
int err;
|
|
|
|
wdev_lock(wdev);
|
|
err = __cfg80211_leave_ocb(rdev, dev);
|
|
wdev_unlock(wdev);
|
|
|
|
return err;
|
|
}
|