mirror of
https://github.com/torvalds/linux
synced 2024-07-08 20:29:39 +00:00
145622771d
If we successfully parsed an interface mode with a legacy switch driver, populate that mode into phylink's supported interfaces rather than defaulting to the internal and gmii interfaces. This hasn't caused an issue so far, because when the interface doesn't match a supported one, phylink_validate() doesn't clear the supported mask, but instead returns -EINVAL. phylink_parse_fixedlink() doesn't check this return value, and merely relies on the supported ethtool link modes mask being cleared. Therefore, the fixed link settings end up being allowed despite validation failing. Before this causes a problem, arrange for DSA to more accurately populate phylink's supported interfaces mask so validation can correctly succeed. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Link: https://lore.kernel.org/r/E1qTKdM-003Cpx-Eh@rmk-PC.armlinux.org.uk Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
||
|---|---|---|
| .. | ||
| devlink.c | ||
| devlink.h | ||
| dsa.c | ||
| dsa.h | ||
| Kconfig | ||
| Makefile | ||
| master.c | ||
| master.h | ||
| netlink.c | ||
| netlink.h | ||
| port.c | ||
| port.h | ||
| slave.c | ||
| slave.h | ||
| stubs.c | ||
| switch.c | ||
| switch.h | ||
| tag_8021q.c | ||
| tag_8021q.h | ||
| tag_ar9331.c | ||
| tag_brcm.c | ||
| tag_dsa.c | ||
| tag_gswip.c | ||
| tag_hellcreek.c | ||
| tag_ksz.c | ||
| tag_lan9303.c | ||
| tag_mtk.c | ||
| tag_none.c | ||
| tag_ocelot_8021q.c | ||
| tag_ocelot.c | ||
| tag_qca.c | ||
| tag_rtl4_a.c | ||
| tag_rtl8_4.c | ||
| tag_rzn1_a5psw.c | ||
| tag_sja1105.c | ||
| tag_trailer.c | ||
| tag_xrs700x.c | ||
| tag.c | ||
| tag.h | ||
| trace.c | ||
| trace.h | ||