Tariq Toukan f08d8c1bb9 net/tls: Fix race in TLS device down flow ... Socket destruction flow and tls_device_down function sync against each other using tls_device_lock and the context refcount, to guarantee the device resources are freed via tls_dev_del() by the end of tls_device_down. In the following unfortunate flow, this won't happen: - refcount is decreased to zero in tls_device_sk_destruct. - tls_device_down starts, skips the context as refcount is zero, going all the way until it flushes the gc work, and returns without freeing the device resources. - only then, tls_device_queue_ctx_destruction is called, queues the gc work and frees the context's device resources. Solve it by decreasing the refcount in the socket's destruction flow under the tls_device_lock, for perfect synchronization. This does not slow down the common likely destructor flow, in which both the refcount is decreased and the spinlock is acquired, anyway. Fixes: e8f6979981 ("net/tls: Add generic NIC offload infrastructure") Reviewed-by: Maxim Mikityanskiy <maximmi@nvidia.com> Signed-off-by: Tariq Toukan <tariqt@nvidia.com> Reviewed-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>		2022-07-18 11:33:07 +01:00
..
Kconfig
Makefile
tls_device.c	net/tls: Fix race in TLS device down flow	2022-07-18 11:33:07 +01:00
tls_device_fallback.c
tls_main.c	net/tls: Check for errors in tls_device_init	2022-07-14 10:12:39 -07:00
tls_proc.c
tls_sw.c
tls_toe.c
trace.c
trace.h