mirror of
https://github.com/torvalds/linux
synced 2024-09-25 05:50:57 +00:00
2e6560929d
XFS gets the sign of the error wrong in several places when gathering the error from generic linux functions. These functions return negative error values, while the core XFS code returns positive error values. Hence when XFS inverts the error to be returned to the VFS, it can incorrectly invert a negative error and this error will be ignored by the syscall return. Fix all the problems related to calling filemap_* functions. Problem initially identified by Nick Piggin in xfs_fsync(). Signed-off-by: Dave Chinner <david@fromorbit.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Niv Sardi <xaiki@sgi.com>
99 lines
2.3 KiB
C
99 lines
2.3 KiB
C
/*
|
|
* Copyright (c) 2000-2002,2005-2006 Silicon Graphics, Inc.
|
|
* All Rights Reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it would be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write the Free Software Foundation,
|
|
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
#include "xfs.h"
|
|
#include "xfs_vnodeops.h"
|
|
#include "xfs_bmap_btree.h"
|
|
#include "xfs_inode.h"
|
|
|
|
int fs_noerr(void) { return 0; }
|
|
int fs_nosys(void) { return ENOSYS; }
|
|
void fs_noval(void) { return; }
|
|
|
|
/*
|
|
* note: all filemap functions return negative error codes. These
|
|
* need to be inverted before returning to the xfs core functions.
|
|
*/
|
|
void
|
|
xfs_tosspages(
|
|
xfs_inode_t *ip,
|
|
xfs_off_t first,
|
|
xfs_off_t last,
|
|
int fiopt)
|
|
{
|
|
struct address_space *mapping = VFS_I(ip)->i_mapping;
|
|
|
|
if (mapping->nrpages)
|
|
truncate_inode_pages(mapping, first);
|
|
}
|
|
|
|
int
|
|
xfs_flushinval_pages(
|
|
xfs_inode_t *ip,
|
|
xfs_off_t first,
|
|
xfs_off_t last,
|
|
int fiopt)
|
|
{
|
|
struct address_space *mapping = VFS_I(ip)->i_mapping;
|
|
int ret = 0;
|
|
|
|
if (mapping->nrpages) {
|
|
xfs_iflags_clear(ip, XFS_ITRUNCATED);
|
|
ret = filemap_write_and_wait(mapping);
|
|
if (!ret)
|
|
truncate_inode_pages(mapping, first);
|
|
}
|
|
return -ret;
|
|
}
|
|
|
|
int
|
|
xfs_flush_pages(
|
|
xfs_inode_t *ip,
|
|
xfs_off_t first,
|
|
xfs_off_t last,
|
|
uint64_t flags,
|
|
int fiopt)
|
|
{
|
|
struct address_space *mapping = VFS_I(ip)->i_mapping;
|
|
int ret = 0;
|
|
int ret2;
|
|
|
|
if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) {
|
|
xfs_iflags_clear(ip, XFS_ITRUNCATED);
|
|
ret = filemap_fdatawrite(mapping);
|
|
if (flags & XFS_B_ASYNC)
|
|
return -ret;
|
|
ret2 = filemap_fdatawait(mapping);
|
|
if (!ret)
|
|
ret = ret2;
|
|
}
|
|
return -ret;
|
|
}
|
|
|
|
int
|
|
xfs_wait_on_pages(
|
|
xfs_inode_t *ip,
|
|
xfs_off_t first,
|
|
xfs_off_t last)
|
|
{
|
|
struct address_space *mapping = VFS_I(ip)->i_mapping;
|
|
|
|
if (mapping_tagged(mapping, PAGECACHE_TAG_WRITEBACK))
|
|
return -filemap_fdatawait(mapping);
|
|
return 0;
|
|
}
|