mirror of
https://github.com/torvalds/linux
synced 2024-11-05 18:23:50 +00:00
fcd70cd36b
Having the probe helper stuff (which pretty much everyone needs) in the drm_crtc_helper.h file (which atomic drivers should never need) is confusing. Split them out. To make sure I actually achieved the goal here I went through all drivers. And indeed, all atomic drivers are now free of drm_crtc_helper.h includes. v2: Make it compile. There was so much compile fail on arm drivers that I figured I'll better not include any of the acks on v1. v3: Massive rebase because i915 has lost a lot of drmP.h includes, but not all: Through drm_crtc_helper.h > drm_modeset_helper.h -> drmP.h there was still one, which this patch largely removes. Which means rolling out lots more includes all over. This will also conflict with ongoing drmP.h cleanup by others I expect. v3: Rebase on top of atomic bochs. v4: Review from Laurent for bridge/rcar/omap/shmob/core bits: - (re)move some of the added includes, use the better include files in other places (all suggested from Laurent adopted unchanged). - sort alphabetically v5: Actually try to sort them, and while at it, sort all the ones I touch. v6: Rebase onto i915 changes. v7: Rebase once more. Acked-by: Harry Wentland <harry.wentland@amd.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> Acked-by: Jani Nikula <jani.nikula@intel.com> Acked-by: Neil Armstrong <narmstrong@baylibre.com> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> Acked-by: CK Hu <ck.hu@mediatek.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: linux-arm-kernel@lists.infradead.org Cc: virtualization@lists.linux-foundation.org Cc: etnaviv@lists.freedesktop.org Cc: linux-samsung-soc@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org Cc: linux-mediatek@lists.infradead.org Cc: linux-amlogic@lists.infradead.org Cc: linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Cc: spice-devel@lists.freedesktop.org Cc: amd-gfx@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-rockchip@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-tegra@vger.kernel.org Cc: xen-devel@lists.xen.org Link: https://patchwork.freedesktop.org/patch/msgid/20190117210334.13234-1-daniel.vetter@ffwll.ch
302 lines
9.2 KiB
C
302 lines
9.2 KiB
C
/*
|
|
* Copyright (C) 2016 Noralf Trønnes
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*/
|
|
|
|
#include <drm/drmP.h>
|
|
#include <drm/drm_atomic.h>
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_plane_helper.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
#include <drm/drm_simple_kms_helper.h>
|
|
#include <linux/slab.h>
|
|
|
|
/**
|
|
* DOC: overview
|
|
*
|
|
* This helper library provides helpers for drivers for simple display
|
|
* hardware.
|
|
*
|
|
* drm_simple_display_pipe_init() initializes a simple display pipeline
|
|
* which has only one full-screen scanout buffer feeding one output. The
|
|
* pipeline is represented by &struct drm_simple_display_pipe and binds
|
|
* together &drm_plane, &drm_crtc and &drm_encoder structures into one fixed
|
|
* entity. Some flexibility for code reuse is provided through a separately
|
|
* allocated &drm_connector object and supporting optional &drm_bridge
|
|
* encoder drivers.
|
|
*/
|
|
|
|
static const struct drm_encoder_funcs drm_simple_kms_encoder_funcs = {
|
|
.destroy = drm_encoder_cleanup,
|
|
};
|
|
|
|
static enum drm_mode_status
|
|
drm_simple_kms_crtc_mode_valid(struct drm_crtc *crtc,
|
|
const struct drm_display_mode *mode)
|
|
{
|
|
struct drm_simple_display_pipe *pipe;
|
|
|
|
pipe = container_of(crtc, struct drm_simple_display_pipe, crtc);
|
|
if (!pipe->funcs || !pipe->funcs->mode_valid)
|
|
/* Anything goes */
|
|
return MODE_OK;
|
|
|
|
return pipe->funcs->mode_valid(crtc, mode);
|
|
}
|
|
|
|
static int drm_simple_kms_crtc_check(struct drm_crtc *crtc,
|
|
struct drm_crtc_state *state)
|
|
{
|
|
bool has_primary = state->plane_mask &
|
|
drm_plane_mask(crtc->primary);
|
|
|
|
/* We always want to have an active plane with an active CRTC */
|
|
if (has_primary != state->enable)
|
|
return -EINVAL;
|
|
|
|
return drm_atomic_add_affected_planes(state->state, crtc);
|
|
}
|
|
|
|
static void drm_simple_kms_crtc_enable(struct drm_crtc *crtc,
|
|
struct drm_crtc_state *old_state)
|
|
{
|
|
struct drm_plane *plane;
|
|
struct drm_simple_display_pipe *pipe;
|
|
|
|
pipe = container_of(crtc, struct drm_simple_display_pipe, crtc);
|
|
if (!pipe->funcs || !pipe->funcs->enable)
|
|
return;
|
|
|
|
plane = &pipe->plane;
|
|
pipe->funcs->enable(pipe, crtc->state, plane->state);
|
|
}
|
|
|
|
static void drm_simple_kms_crtc_disable(struct drm_crtc *crtc,
|
|
struct drm_crtc_state *old_state)
|
|
{
|
|
struct drm_simple_display_pipe *pipe;
|
|
|
|
pipe = container_of(crtc, struct drm_simple_display_pipe, crtc);
|
|
if (!pipe->funcs || !pipe->funcs->disable)
|
|
return;
|
|
|
|
pipe->funcs->disable(pipe);
|
|
}
|
|
|
|
static const struct drm_crtc_helper_funcs drm_simple_kms_crtc_helper_funcs = {
|
|
.mode_valid = drm_simple_kms_crtc_mode_valid,
|
|
.atomic_check = drm_simple_kms_crtc_check,
|
|
.atomic_enable = drm_simple_kms_crtc_enable,
|
|
.atomic_disable = drm_simple_kms_crtc_disable,
|
|
};
|
|
|
|
static int drm_simple_kms_crtc_enable_vblank(struct drm_crtc *crtc)
|
|
{
|
|
struct drm_simple_display_pipe *pipe;
|
|
|
|
pipe = container_of(crtc, struct drm_simple_display_pipe, crtc);
|
|
if (!pipe->funcs || !pipe->funcs->enable_vblank)
|
|
return 0;
|
|
|
|
return pipe->funcs->enable_vblank(pipe);
|
|
}
|
|
|
|
static void drm_simple_kms_crtc_disable_vblank(struct drm_crtc *crtc)
|
|
{
|
|
struct drm_simple_display_pipe *pipe;
|
|
|
|
pipe = container_of(crtc, struct drm_simple_display_pipe, crtc);
|
|
if (!pipe->funcs || !pipe->funcs->disable_vblank)
|
|
return;
|
|
|
|
pipe->funcs->disable_vblank(pipe);
|
|
}
|
|
|
|
static const struct drm_crtc_funcs drm_simple_kms_crtc_funcs = {
|
|
.reset = drm_atomic_helper_crtc_reset,
|
|
.destroy = drm_crtc_cleanup,
|
|
.set_config = drm_atomic_helper_set_config,
|
|
.page_flip = drm_atomic_helper_page_flip,
|
|
.atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
|
|
.atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
|
|
.enable_vblank = drm_simple_kms_crtc_enable_vblank,
|
|
.disable_vblank = drm_simple_kms_crtc_disable_vblank,
|
|
};
|
|
|
|
static int drm_simple_kms_plane_atomic_check(struct drm_plane *plane,
|
|
struct drm_plane_state *plane_state)
|
|
{
|
|
struct drm_simple_display_pipe *pipe;
|
|
struct drm_crtc_state *crtc_state;
|
|
int ret;
|
|
|
|
pipe = container_of(plane, struct drm_simple_display_pipe, plane);
|
|
crtc_state = drm_atomic_get_new_crtc_state(plane_state->state,
|
|
&pipe->crtc);
|
|
|
|
ret = drm_atomic_helper_check_plane_state(plane_state, crtc_state,
|
|
DRM_PLANE_HELPER_NO_SCALING,
|
|
DRM_PLANE_HELPER_NO_SCALING,
|
|
false, true);
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (!plane_state->visible)
|
|
return 0;
|
|
|
|
if (!pipe->funcs || !pipe->funcs->check)
|
|
return 0;
|
|
|
|
return pipe->funcs->check(pipe, plane_state, crtc_state);
|
|
}
|
|
|
|
static void drm_simple_kms_plane_atomic_update(struct drm_plane *plane,
|
|
struct drm_plane_state *old_pstate)
|
|
{
|
|
struct drm_simple_display_pipe *pipe;
|
|
|
|
pipe = container_of(plane, struct drm_simple_display_pipe, plane);
|
|
if (!pipe->funcs || !pipe->funcs->update)
|
|
return;
|
|
|
|
pipe->funcs->update(pipe, old_pstate);
|
|
}
|
|
|
|
static int drm_simple_kms_plane_prepare_fb(struct drm_plane *plane,
|
|
struct drm_plane_state *state)
|
|
{
|
|
struct drm_simple_display_pipe *pipe;
|
|
|
|
pipe = container_of(plane, struct drm_simple_display_pipe, plane);
|
|
if (!pipe->funcs || !pipe->funcs->prepare_fb)
|
|
return 0;
|
|
|
|
return pipe->funcs->prepare_fb(pipe, state);
|
|
}
|
|
|
|
static void drm_simple_kms_plane_cleanup_fb(struct drm_plane *plane,
|
|
struct drm_plane_state *state)
|
|
{
|
|
struct drm_simple_display_pipe *pipe;
|
|
|
|
pipe = container_of(plane, struct drm_simple_display_pipe, plane);
|
|
if (!pipe->funcs || !pipe->funcs->cleanup_fb)
|
|
return;
|
|
|
|
pipe->funcs->cleanup_fb(pipe, state);
|
|
}
|
|
|
|
static bool drm_simple_kms_format_mod_supported(struct drm_plane *plane,
|
|
uint32_t format,
|
|
uint64_t modifier)
|
|
{
|
|
return modifier == DRM_FORMAT_MOD_LINEAR;
|
|
}
|
|
|
|
static const struct drm_plane_helper_funcs drm_simple_kms_plane_helper_funcs = {
|
|
.prepare_fb = drm_simple_kms_plane_prepare_fb,
|
|
.cleanup_fb = drm_simple_kms_plane_cleanup_fb,
|
|
.atomic_check = drm_simple_kms_plane_atomic_check,
|
|
.atomic_update = drm_simple_kms_plane_atomic_update,
|
|
};
|
|
|
|
static const struct drm_plane_funcs drm_simple_kms_plane_funcs = {
|
|
.update_plane = drm_atomic_helper_update_plane,
|
|
.disable_plane = drm_atomic_helper_disable_plane,
|
|
.destroy = drm_plane_cleanup,
|
|
.reset = drm_atomic_helper_plane_reset,
|
|
.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
|
|
.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
|
|
.format_mod_supported = drm_simple_kms_format_mod_supported,
|
|
};
|
|
|
|
/**
|
|
* drm_simple_display_pipe_attach_bridge - Attach a bridge to the display pipe
|
|
* @pipe: simple display pipe object
|
|
* @bridge: bridge to attach
|
|
*
|
|
* Makes it possible to still use the drm_simple_display_pipe helpers when
|
|
* a DRM bridge has to be used.
|
|
*
|
|
* Note that you probably want to initialize the pipe by passing a NULL
|
|
* connector to drm_simple_display_pipe_init().
|
|
*
|
|
* Returns:
|
|
* Zero on success, negative error code on failure.
|
|
*/
|
|
int drm_simple_display_pipe_attach_bridge(struct drm_simple_display_pipe *pipe,
|
|
struct drm_bridge *bridge)
|
|
{
|
|
return drm_bridge_attach(&pipe->encoder, bridge, NULL);
|
|
}
|
|
EXPORT_SYMBOL(drm_simple_display_pipe_attach_bridge);
|
|
|
|
/**
|
|
* drm_simple_display_pipe_init - Initialize a simple display pipeline
|
|
* @dev: DRM device
|
|
* @pipe: simple display pipe object to initialize
|
|
* @funcs: callbacks for the display pipe (optional)
|
|
* @formats: array of supported formats (DRM_FORMAT\_\*)
|
|
* @format_count: number of elements in @formats
|
|
* @format_modifiers: array of formats modifiers
|
|
* @connector: connector to attach and register (optional)
|
|
*
|
|
* Sets up a display pipeline which consist of a really simple
|
|
* plane-crtc-encoder pipe.
|
|
*
|
|
* If a connector is supplied, the pipe will be coupled with the provided
|
|
* connector. You may supply a NULL connector when using drm bridges, that
|
|
* handle connectors themselves (see drm_simple_display_pipe_attach_bridge()).
|
|
*
|
|
* Teardown of a simple display pipe is all handled automatically by the drm
|
|
* core through calling drm_mode_config_cleanup(). Drivers afterwards need to
|
|
* release the memory for the structure themselves.
|
|
*
|
|
* Returns:
|
|
* Zero on success, negative error code on failure.
|
|
*/
|
|
int drm_simple_display_pipe_init(struct drm_device *dev,
|
|
struct drm_simple_display_pipe *pipe,
|
|
const struct drm_simple_display_pipe_funcs *funcs,
|
|
const uint32_t *formats, unsigned int format_count,
|
|
const uint64_t *format_modifiers,
|
|
struct drm_connector *connector)
|
|
{
|
|
struct drm_encoder *encoder = &pipe->encoder;
|
|
struct drm_plane *plane = &pipe->plane;
|
|
struct drm_crtc *crtc = &pipe->crtc;
|
|
int ret;
|
|
|
|
pipe->connector = connector;
|
|
pipe->funcs = funcs;
|
|
|
|
drm_plane_helper_add(plane, &drm_simple_kms_plane_helper_funcs);
|
|
ret = drm_universal_plane_init(dev, plane, 0,
|
|
&drm_simple_kms_plane_funcs,
|
|
formats, format_count,
|
|
format_modifiers,
|
|
DRM_PLANE_TYPE_PRIMARY, NULL);
|
|
if (ret)
|
|
return ret;
|
|
|
|
drm_crtc_helper_add(crtc, &drm_simple_kms_crtc_helper_funcs);
|
|
ret = drm_crtc_init_with_planes(dev, crtc, plane, NULL,
|
|
&drm_simple_kms_crtc_funcs, NULL);
|
|
if (ret)
|
|
return ret;
|
|
|
|
encoder->possible_crtcs = drm_crtc_mask(crtc);
|
|
ret = drm_encoder_init(dev, encoder, &drm_simple_kms_encoder_funcs,
|
|
DRM_MODE_ENCODER_NONE, NULL);
|
|
if (ret || !connector)
|
|
return ret;
|
|
|
|
return drm_connector_attach_encoder(connector, encoder);
|
|
}
|
|
EXPORT_SYMBOL(drm_simple_display_pipe_init);
|
|
|
|
MODULE_LICENSE("GPL");
|