linux/drivers/virt/acrn
Len Baker 746f1b0ac5 virt: acrn: Prefer array_size and struct_size over open coded arithmetic
As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the array_size() helper to do the arithmetic instead of the
argument "count * size" in the vzalloc() function.

Also, take the opportunity to add a flexible array member of struct
vm_memory_region_op to the vm_memory_region_batch structure. And then,
change the code accordingly and use the struct_size() helper to do the
arithmetic instead of the argument "size + size * count" in the kzalloc
function.

This code was detected with the help of Coccinelle and audited and fixed
manually.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Acked-by: Fei Li <fei1.li@intel.com>
Signed-off-by: Len Baker <len.baker@gmx.com>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
2022-04-26 10:20:10 -05:00
..
acrn_drv.h virt: acrn: Prefer array_size and struct_size over open coded arithmetic 2022-04-26 10:20:10 -05:00
hsm.c virt: acrn: fix a memory leak in acrn_dev_ioctl() 2022-03-18 13:49:59 +01:00
hypercall.h virt: acrn: Introduce interfaces for virtual device creating/destroying 2021-10-05 16:14:10 +02:00
ioeventfd.c virt: acrn: Introduce ioeventfd 2021-02-09 10:58:19 +01:00
ioreq.c all: replace find_next{,_zero}_bit with find_first{,_zero}_bit where appropriate 2022-01-15 08:47:31 -08:00
irqfd.c virt: acrn: Remove unsued acrn_irqfds_mutex. 2022-03-18 13:49:49 +01:00
Kconfig virt: acrn: Introduce ioeventfd 2021-02-09 10:58:19 +01:00
Makefile virt: acrn: Introduce irqfd 2021-02-09 10:58:19 +01:00
mm.c virt: acrn: Prefer array_size and struct_size over open coded arithmetic 2022-04-26 10:20:10 -05:00
vm.c virt: acrn: Do hcall_destroy_vm() before resource release 2021-07-27 16:48:45 +02:00