mirror of
https://github.com/torvalds/linux
synced 2024-10-20 18:28:21 +00:00
17a17bf506
The mmc core uses a PM notifier to temporarily during system suspend, turn off the card detection mechanism for removal/insertion of (e)MMC/SD/SDIO cards. Additionally, the notifier may be used to remove an SDIO card entirely, if a corresponding SDIO functional driver don't have the system suspend/resume callbacks assigned. This behaviour has been around for a very long time. However, a recent bug report tells us there are problems with this approach. More precisely, when receiving the PM_SUSPEND_PREPARE notification, we may end up hanging on I/O to be completed, thus also preventing the system from getting suspended. In the end what happens, is that the cancel_delayed_work_sync() in mmc_pm_notify() ends up waiting for mmc_rescan() to complete - and since mmc_rescan() wants to claim the host, it needs to wait for the I/O to be completed first. Typically, this problem is triggered in Android, if there is ongoing I/O while the user decides to suspend, resume and then suspend the system again. This due to that after the resume, an mmc_rescan() work gets punted to the workqueue, which job is to verify that the card remains inserted after the system has resumed. To fix this problem, userspace needs to become frozen to suspend the I/O, prior to turning off the card detection mechanism. Therefore, let's drop the PM notifiers for mmc subsystem altogether and rely on the card detection to be turned off/on as a part of the system_freezable_wq, that we are already using. Moreover, to allow and SDIO card to be removed during system suspend, let's manage this from a ->prepare() callback, assigned at the mmc_host_class level. In this way, we can use the parent device (the mmc_host_class device), to remove the card device that is the child, in the device_prepare() phase. Reported-by: Kiwoong Kim <kwmad.kim@samsung.com> Cc: stable@vger.kernel.org # v4.5+ Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20210310152900.149380-1-ulf.hansson@linaro.org Reviewed-by: Kiwoong Kim <kwmad.kim@samsung.com>
167 lines
5.4 KiB
C
167 lines
5.4 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* linux/drivers/mmc/core/core.h
|
|
*
|
|
* Copyright (C) 2003 Russell King, All Rights Reserved.
|
|
* Copyright 2007 Pierre Ossman
|
|
*/
|
|
#ifndef _MMC_CORE_CORE_H
|
|
#define _MMC_CORE_CORE_H
|
|
|
|
#include <linux/delay.h>
|
|
#include <linux/sched.h>
|
|
|
|
struct mmc_host;
|
|
struct mmc_card;
|
|
struct mmc_request;
|
|
|
|
#define MMC_CMD_RETRIES 3
|
|
|
|
struct mmc_bus_ops {
|
|
void (*remove)(struct mmc_host *);
|
|
void (*detect)(struct mmc_host *);
|
|
int (*pre_suspend)(struct mmc_host *);
|
|
int (*suspend)(struct mmc_host *);
|
|
int (*resume)(struct mmc_host *);
|
|
int (*runtime_suspend)(struct mmc_host *);
|
|
int (*runtime_resume)(struct mmc_host *);
|
|
int (*alive)(struct mmc_host *);
|
|
int (*shutdown)(struct mmc_host *);
|
|
int (*hw_reset)(struct mmc_host *);
|
|
int (*sw_reset)(struct mmc_host *);
|
|
};
|
|
|
|
void mmc_attach_bus(struct mmc_host *host, const struct mmc_bus_ops *ops);
|
|
void mmc_detach_bus(struct mmc_host *host);
|
|
|
|
struct device_node *mmc_of_find_child_device(struct mmc_host *host,
|
|
unsigned func_num);
|
|
|
|
void mmc_init_erase(struct mmc_card *card);
|
|
|
|
void mmc_set_chip_select(struct mmc_host *host, int mode);
|
|
void mmc_set_clock(struct mmc_host *host, unsigned int hz);
|
|
void mmc_set_bus_mode(struct mmc_host *host, unsigned int mode);
|
|
void mmc_set_bus_width(struct mmc_host *host, unsigned int width);
|
|
u32 mmc_select_voltage(struct mmc_host *host, u32 ocr);
|
|
int mmc_set_uhs_voltage(struct mmc_host *host, u32 ocr);
|
|
int mmc_host_set_uhs_voltage(struct mmc_host *host);
|
|
int mmc_set_signal_voltage(struct mmc_host *host, int signal_voltage);
|
|
void mmc_set_initial_signal_voltage(struct mmc_host *host);
|
|
void mmc_set_timing(struct mmc_host *host, unsigned int timing);
|
|
void mmc_set_driver_type(struct mmc_host *host, unsigned int drv_type);
|
|
int mmc_select_drive_strength(struct mmc_card *card, unsigned int max_dtr,
|
|
int card_drv_type, int *drv_type);
|
|
void mmc_power_up(struct mmc_host *host, u32 ocr);
|
|
void mmc_power_off(struct mmc_host *host);
|
|
void mmc_power_cycle(struct mmc_host *host, u32 ocr);
|
|
void mmc_set_initial_state(struct mmc_host *host);
|
|
u32 mmc_vddrange_to_ocrmask(int vdd_min, int vdd_max);
|
|
|
|
static inline void mmc_delay(unsigned int ms)
|
|
{
|
|
if (ms <= 20)
|
|
usleep_range(ms * 1000, ms * 1250);
|
|
else
|
|
msleep(ms);
|
|
}
|
|
|
|
void mmc_rescan(struct work_struct *work);
|
|
void mmc_start_host(struct mmc_host *host);
|
|
void mmc_stop_host(struct mmc_host *host);
|
|
|
|
void _mmc_detect_change(struct mmc_host *host, unsigned long delay,
|
|
bool cd_irq);
|
|
int _mmc_detect_card_removed(struct mmc_host *host);
|
|
int mmc_detect_card_removed(struct mmc_host *host);
|
|
|
|
int mmc_attach_mmc(struct mmc_host *host);
|
|
int mmc_attach_sd(struct mmc_host *host);
|
|
int mmc_attach_sdio(struct mmc_host *host);
|
|
|
|
/* Module parameters */
|
|
extern bool use_spi_crc;
|
|
|
|
/* Debugfs information for hosts and cards */
|
|
void mmc_add_host_debugfs(struct mmc_host *host);
|
|
void mmc_remove_host_debugfs(struct mmc_host *host);
|
|
|
|
void mmc_add_card_debugfs(struct mmc_card *card);
|
|
void mmc_remove_card_debugfs(struct mmc_card *card);
|
|
|
|
int mmc_execute_tuning(struct mmc_card *card);
|
|
int mmc_hs200_to_hs400(struct mmc_card *card);
|
|
int mmc_hs400_to_hs200(struct mmc_card *card);
|
|
|
|
void mmc_wait_for_req_done(struct mmc_host *host, struct mmc_request *mrq);
|
|
bool mmc_is_req_done(struct mmc_host *host, struct mmc_request *mrq);
|
|
|
|
int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq);
|
|
|
|
int mmc_erase(struct mmc_card *card, unsigned int from, unsigned int nr,
|
|
unsigned int arg);
|
|
int mmc_can_erase(struct mmc_card *card);
|
|
int mmc_can_trim(struct mmc_card *card);
|
|
int mmc_can_discard(struct mmc_card *card);
|
|
int mmc_can_sanitize(struct mmc_card *card);
|
|
int mmc_can_secure_erase_trim(struct mmc_card *card);
|
|
int mmc_erase_group_aligned(struct mmc_card *card, unsigned int from,
|
|
unsigned int nr);
|
|
unsigned int mmc_calc_max_discard(struct mmc_card *card);
|
|
|
|
int mmc_set_blocklen(struct mmc_card *card, unsigned int blocklen);
|
|
|
|
int __mmc_claim_host(struct mmc_host *host, struct mmc_ctx *ctx,
|
|
atomic_t *abort);
|
|
void mmc_release_host(struct mmc_host *host);
|
|
void mmc_get_card(struct mmc_card *card, struct mmc_ctx *ctx);
|
|
void mmc_put_card(struct mmc_card *card, struct mmc_ctx *ctx);
|
|
|
|
/**
|
|
* mmc_claim_host - exclusively claim a host
|
|
* @host: mmc host to claim
|
|
*
|
|
* Claim a host for a set of operations.
|
|
*/
|
|
static inline void mmc_claim_host(struct mmc_host *host)
|
|
{
|
|
__mmc_claim_host(host, NULL, NULL);
|
|
}
|
|
|
|
int mmc_cqe_start_req(struct mmc_host *host, struct mmc_request *mrq);
|
|
void mmc_cqe_post_req(struct mmc_host *host, struct mmc_request *mrq);
|
|
int mmc_cqe_recovery(struct mmc_host *host);
|
|
|
|
/**
|
|
* mmc_pre_req - Prepare for a new request
|
|
* @host: MMC host to prepare command
|
|
* @mrq: MMC request to prepare for
|
|
*
|
|
* mmc_pre_req() is called in prior to mmc_start_req() to let
|
|
* host prepare for the new request. Preparation of a request may be
|
|
* performed while another request is running on the host.
|
|
*/
|
|
static inline void mmc_pre_req(struct mmc_host *host, struct mmc_request *mrq)
|
|
{
|
|
if (host->ops->pre_req)
|
|
host->ops->pre_req(host, mrq);
|
|
}
|
|
|
|
/**
|
|
* mmc_post_req - Post process a completed request
|
|
* @host: MMC host to post process command
|
|
* @mrq: MMC request to post process for
|
|
* @err: Error, if non zero, clean up any resources made in pre_req
|
|
*
|
|
* Let the host post process a completed request. Post processing of
|
|
* a request may be performed while another request is running.
|
|
*/
|
|
static inline void mmc_post_req(struct mmc_host *host, struct mmc_request *mrq,
|
|
int err)
|
|
{
|
|
if (host->ops->post_req)
|
|
host->ops->post_req(host, mrq, err);
|
|
}
|
|
|
|
#endif
|