mirror of
https://github.com/torvalds/linux
synced 2024-11-05 18:23:50 +00:00
b9f174c811
Commitsffb1b4a410("x86/unwind/orc: Add 'signal' field to ORC metadata") andfb799447ae("x86,objtool: Split UNWIND_HINT_EMPTY in two") changed the ORC format. Although ORC is internal to the kernel, it's the only way for external tools to get reliable kernel stack traces on x86-64. In particular, the drgn debugger [1] uses ORC for stack unwinding, and these format changes broke it [2]. As the drgn maintainer, I don't care how often or how much the kernel changes the ORC format as long as I have a way to detect the change. It suffices to store a version identifier in the vmlinux and kernel module ELF files (to use when parsing ORC sections from ELF), and in kernel memory (to use when parsing ORC from a core dump+symbol table). Rather than hard-coding a version number that needs to be manually bumped, Peterz suggested hashing the definitions from orc_types.h. If there is a format change that isn't caught by this, the hashing script can be updated. This patch adds an .orc_header allocated ELF section containing the 20-byte hash to vmlinux and kernel modules, along with the corresponding __start_orc_header and __stop_orc_header symbols in vmlinux. 1: https://github.com/osandov/drgn 2: https://github.com/osandov/drgn/issues/303 Fixes:ffb1b4a410("x86/unwind/orc: Add 'signal' field to ORC metadata") Fixes:fb799447ae("x86,objtool: Split UNWIND_HINT_EMPTY in two") Signed-off-by: Omar Sandoval <osandov@fb.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Josh Poimboeuf <jpoimboe@kernel.org> Link: https://lkml.kernel.org/r/aef9c8dc43915b886a8c48509a12ec1b006ca1ca.1686690801.git.osandov@osandov.com
16 lines
316 B
Bash
16 lines
316 B
Bash
#!/bin/sh
|
|
# SPDX-License-Identifier: GPL-2.0-or-later
|
|
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
|
|
set -e
|
|
|
|
printf '%s' '#define ORC_HASH '
|
|
|
|
awk '
|
|
/^#define ORC_(REG|TYPE)_/ { print }
|
|
/^struct orc_entry {$/ { p=1 }
|
|
p { print }
|
|
/^}/ { p=0 }' |
|
|
sha1sum |
|
|
cut -d " " -f 1 |
|
|
sed 's/\([0-9a-f]\{2\}\)/0x\1,/g'
|