Chao Yu e2374015f2 f2fs: fix to propagate return value of scan_nat_page() ... As Anatoly Trosinenko reported in bugzilla: How to reproduce: 1. Compile the 73fcb1a370 version of the kernel using the config attached 2. Unpack and mount the attached filesystem image as F2FS 3. The kernel will BUG() on mount (BUGs are explicitly enabled in config) [ 2.233612] F2FS-fs (sda): Found nat_bits in checkpoint [ 2.248422] ------------[ cut here ]------------ [ 2.248857] kernel BUG at fs/f2fs/node.c:1967! [ 2.249760] invalid opcode: 0000 [#1] SMP NOPTI [ 2.250219] Modules linked in: [ 2.251848] CPU: 0 PID: 944 Comm: mount Not tainted 4.17.0-rc5+ #1 [ 2.252331] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014 [ 2.253305] RIP: 0010:build_free_nids+0x337/0x3f0 [ 2.253672] RSP: 0018:ffffae7fc0857c50 EFLAGS: 00000246 [ 2.254080] RAX: 00000000ffffffff RBX: 0000000000000123 RCX: 0000000000000001 [ 2.254638] RDX: ffff9aa7063d5c00 RSI: 0000000000000122 RDI: ffff9aa705852e00 [ 2.255190] RBP: ffff9aa705852e00 R08: 0000000000000001 R09: ffff9aa7059090c0 [ 2.255719] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9aa705852e00 [ 2.256242] R13: ffff9aa7063ad000 R14: ffff9aa705919000 R15: 0000000000000123 [ 2.256809] FS: 00000000023078c0(0000) GS:ffff9aa707800000(0000) knlGS:0000000000000000 [ 2.258654] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 2.259153] CR2: 00000000005511ae CR3: 0000000005872000 CR4: 00000000000006f0 [ 2.259801] Call Trace: [ 2.260583] build_node_manager+0x5cd/0x600 [ 2.260963] f2fs_fill_super+0x66a/0x17c0 [ 2.261300] ? f2fs_commit_super+0xe0/0xe0 [ 2.261622] mount_bdev+0x16e/0x1a0 [ 2.261899] mount_fs+0x30/0x150 [ 2.262398] vfs_kern_mount.part.28+0x4f/0xf0 [ 2.262743] do_mount+0x5d0/0xc60 [ 2.263010] ? _copy_from_user+0x37/0x60 [ 2.263313] ? memdup_user+0x39/0x60 [ 2.263692] ksys_mount+0x7b/0xd0 [ 2.263960] __x64_sys_mount+0x1c/0x20 [ 2.264268] do_syscall_64+0x43/0xf0 [ 2.264560] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 2.265095] RIP: 0033:0x48d31a [ 2.265502] RSP: 002b:00007ffc6fe60a08 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 [ 2.266089] RAX: ffffffffffffffda RBX: 0000000000008000 RCX: 000000000048d31a [ 2.266607] RDX: 00007ffc6fe62fa5 RSI: 00007ffc6fe62f9d RDI: 00007ffc6fe62f94 [ 2.267130] RBP: 00000000023078a0 R08: 0000000000000000 R09: 0000000000000000 [ 2.267670] R10: 0000000000008000 R11: 0000000000000246 R12: 0000000000000000 [ 2.268192] R13: 0000000000000000 R14: 00007ffc6fe60c78 R15: 0000000000000000 [ 2.268767] Code: e8 5f c3 ff ff 83 c3 01 41 83 c7 01 81 fb c7 01 00 00 74 48 44 39 7d 04 76 42 48 63 c3 48 8d 04 c0 41 8b 44 06 05 83 f8 ff 75 c1 <0f> 0b 49 8b 45 50 48 8d b8 b0 00 00 00 e8 37 59 69 00 b9 01 00 [ 2.270434] RIP: build_free_nids+0x337/0x3f0 RSP: ffffae7fc0857c50 [ 2.271426] ---[ end trace ab20c06cd3c8fde4 ]--- During loading NAT entries, we will do sanity check, once the entry info is corrupted, it will cause BUG_ON directly to protect user data from being overwrited. In this case, it will be better to just return failure on mount() instead of panic, so that user can get hint from kmsg and try fsck for recovery immediately rather than after an abnormal reboot. https://bugzilla.kernel.org/show_bug.cgi?id=199769 Reported-by: Anatoly Trosinenko <anatoly.trosinenko@gmail.com> Signed-off-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>		2018-07-27 18:03:59 +09:00
..
9p	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
adfs	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
affs	affs: fix potential memory leak when parsing option 'prefix'	2018-05-28 12:36:41 +02:00
afs	Merge branch 'afs-proc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-06-16 16:32:04 +09:00
autofs	autofs: rename 'autofs' module back to 'autofs4'	2018-07-05 11:35:04 -07:00
befs	fix a series of Documentation/ broken file name references	2018-06-15 18:10:01 -03:00
bfs	bfs_add_entry: pass name/len as qstr pointer	2018-05-22 14:27:50 -04:00
btrfs	for-4.18-rc2-tag	2018-07-01 12:38:16 -07:00
cachefiles	Merge branch 'hch.procfs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-06-04 10:00:01 -07:00
ceph	ceph: fix dentry leak in splice_dentry()	2018-06-26 18:42:44 +02:00
cifs	cifs: Fix invalid check in __cifs_calc_signature()	2018-06-15 19:17:40 -05:00
coda	vfs: change inode times to use struct timespec64	2018-06-05 16:57:31 -07:00
configfs	vfs: change inode times to use struct timespec64	2018-06-05 16:57:31 -07:00
cramfs	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
crypto	f2fs-for-4.18-rc1	2018-06-11 10:16:13 -07:00
debugfs	Revert "debugfs: inode: debugfs_create_dir uses mode permission from parent"	2018-06-12 20:52:16 -07:00
devpts	devpts: comment devpts_mntget()	2018-03-14 13:31:23 +01:00
dlm	treewide: Use array_size() in vmalloc()	2018-06-12 16:19:22 -07:00
ecryptfs	Merge branch 'fixes' of https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs into aio-base	2018-05-26 09:16:25 +02:00
efivarfs	efivarfs: Limit the rate for non-root to read files	2018-02-22 10:21:02 -08:00
efs
exofs	exofs: avoid VLA in structures	2018-06-15 07:55:24 +09:00
exportfs	ovl: do not try to reconnect a disconnected origin dentry	2018-04-12 12:04:49 +02:00
ext2	ext2: add warning when specifying nocheck option	2018-06-20 11:04:26 +02:00
ext4	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
f2fs	f2fs: fix to propagate return value of scan_nat_page()	2018-07-27 18:03:59 +09:00
fat	Merge branch 'akpm' (patches from Andrew)	2018-06-15 08:51:42 +09:00
freevxfs	freevxfs_lookup(): use d_splice_alias()	2018-05-22 14:27:51 -04:00
fscache	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
fuse	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
gfs2	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
hfs	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
hfsplus	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
hostfs	vfs: change inode times to use struct timespec64	2018-06-05 16:57:31 -07:00
hpfs	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
hugetlbfs	hugetlbfs: fix bug in pgoff overflow checking	2018-04-05 21:36:21 -07:00
isofs	isofs: fix potential memory leak in mount option parsing	2018-04-16 09:47:41 +02:00
jbd2	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
jffs2	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
jfs	This fixes a too-small allocation in the xattr code.	2018-06-19 07:47:32 +09:00
kernfs	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
lockd	net: Drop pernet_operations::async	2018-03-27 13:18:09 -04:00
minix	minix_lookup: use d_splice_alias()	2018-05-22 14:27:52 -04:00
nfs	NFS client bugfixes for Linux 4.18	2018-06-22 06:21:34 +09:00
nfs_common	net: Drop pernet_operations::async	2018-03-27 13:18:09 -04:00
nfsd	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
nilfs2	do d_instantiate/unlock_new_inode combinations safely	2018-05-11 15:36:37 -04:00
nls
notify	fsnotify: add fsnotify_add_inode_mark() wrappers	2018-05-18 14:58:22 +02:00
ntfs	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
ocfs2	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
omfs	omfs_lookup(): report IO errors, use d_splice_alias()	2018-05-22 14:27:58 -04:00
openpromfs	openpromfs: switch to d_splice_alias()	2018-05-22 14:27:57 -04:00
orangefs	Solve a series of broken links for files under Documentation:	2018-06-17 05:25:18 +09:00
overlayfs	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
proc	Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-07-01 12:32:19 -07:00
pstore	pstore: Remove bogus format string definition	2018-06-14 14:57:24 +02:00
qnx4	qnx4_lookup: use d_splice_alias()	2018-05-22 14:27:52 -04:00
qnx6	qnx6_lookup: switch to d_splice_alias()	2018-05-22 14:27:54 -04:00
quota	quota: Cleanup list iteration in dqcache_shrink_scan()	2018-06-20 11:04:26 +02:00
ramfs
reiserfs	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
romfs	romfs_lookup: switch to d_splice_alias()	2018-05-22 14:27:55 -04:00
squashfs
sysfs	unfuck sysfs_mount()	2018-05-21 14:30:09 -04:00
sysv	sysv_lookup: use d_splice_alias()	2018-05-22 14:27:53 -04:00
tracefs
ubifs	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
udf	udf: Drop unused arguments of udf_delete_aext()	2018-06-20 11:05:49 +02:00
ufs	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
xfs	xfs: fix fdblocks accounting w/ RMAPBT per-AG reservation	2018-06-24 12:00:12 -07:00
aio.c	Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL	2018-06-28 10:40:47 -07:00
anon_inodes.c
attr.c	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
bad_inode.c	vfs: change inode times to use struct timespec64	2018-06-05 16:57:31 -07:00
binfmt_aout.c	exec: introduce finalize_exec() before start_thread()	2018-04-11 10:28:37 -07:00
binfmt_elf.c	coredump: fix spam with zero VMA process	2018-06-15 07:55:24 +09:00
binfmt_elf_fdpic.c	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
binfmt_em86.c
binfmt_flat.c	exec: introduce finalize_exec() before start_thread()	2018-04-11 10:28:37 -07:00
binfmt_misc.c	docs: Fix more broken references	2018-06-15 18:11:26 -03:00
binfmt_script.c
block_dev.c	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
buffer.c	fs: move page_cache_seek_hole_data to iomap.c	2018-06-01 18:37:33 -07:00
char_dev.c	block, char_dev: Use correct format specifier for unsigned ints	2018-03-15 17:59:24 +01:00
compat.c	ncpfs: remove compat functionality	2018-06-05 19:23:26 +02:00
compat_binfmt_elf.c
compat_ioctl.c	autofs: clean up includes	2018-06-07 17:34:40 -07:00
coredump.c
d_path.c	split d_path() and friends into a separate file	2018-03-29 15:07:46 -04:00
dax.c	libnvdimm for 4.18	2018-06-08 17:21:52 -07:00
dcache.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-06-04 10:14:28 -07:00
dcookies.c	fs: add do_lookup_dcookie() helper; remove in-kernel call to syscall	2018-04-02 20:15:39 +02:00
direct-io.c	block: consistently use GFP_NOIO instead of __GFP_NORECLAIM	2018-05-14 08:55:18 -06:00
drop_caches.c
eventfd.c	Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL	2018-06-28 10:40:47 -07:00
eventpoll.c	Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL	2018-06-28 10:40:47 -07:00
exec.c	Merge branch 'core-rseq-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-06-10 10:17:09 -07:00
fcntl.c	mm: restructure memfd code	2018-06-07 17:34:35 -07:00
fhandle.c
file.c	fs: add ksys_close() wrapper; remove in-kernel calls to sys_close()	2018-04-02 20:16:00 +02:00
file_table.c
filesystems.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
fs-writeback.c	bdi: Fix oops in wb_workfn()	2018-05-03 16:11:37 -06:00
fs_pin.c
fs_struct.c
inode.c	Fix up non-directory creation in SGID directories	2018-07-05 12:36:36 -07:00
internal.h	Revert "fs: fold open_check_o_direct into do_dentry_open"	2018-06-03 10:58:23 -07:00
ioctl.c	fs: Allow CAP_SYS_ADMIN in s_user_ns to freeze and thaw filesystems	2018-05-24 12:04:28 -05:00
iomap.c	Changes since last update:	2018-06-12 15:49:00 -07:00
Kconfig	autofs: remove left-over autofs4 stubs	2018-06-11 08:22:34 -07:00
Kconfig.binfmt	docs: Fix more broken references	2018-06-15 18:11:26 -03:00
libfs.c	fs, dax: prepare for dax-specific address_space_operations	2018-03-30 11:34:55 -07:00
locks.c	vfs/y2038: inode timestamps conversion to timespec64	2018-06-15 07:31:07 +09:00
Makefile	autofs: remove left-over autofs4 stubs	2018-06-11 08:22:34 -07:00
mbcache.c	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
mount.h
mpage.c
namei.c	Merge branch 'afs-proc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-06-16 16:32:04 +09:00
namespace.c	fs: Allow superblock owner to access do_remount_sb()	2018-05-24 12:02:25 -05:00
no-block.c
nsfs.c
open.c	Revert "fs: fold open_check_o_direct into do_dentry_open"	2018-06-03 10:58:23 -07:00
pipe.c	Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL	2018-06-28 10:40:47 -07:00
pnode.c
pnode.h
posix_acl.c
proc_namespace.c
read_write.c	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
readdir.c	fs: add ksys_getdents64() helper; remove in-kernel calls to sys_getdents64()	2018-04-02 20:16:02 +02:00
select.c	Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL	2018-06-28 10:40:47 -07:00
seq_file.c	proc: fix smaps and meminfo alignment	2018-05-25 18:12:11 -07:00
signalfd.c	Merge branch 'work.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-06-16 16:21:50 +09:00
splice.c	Merge branch 'work.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-06-16 16:21:50 +09:00
stack.c
stat.c	fs: add do_readlinkat() helper; remove internal call to sys_readlinkat()	2018-04-02 20:15:34 +02:00
statfs.c
super.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-06-04 10:14:28 -07:00
sync.c	Changes for this release:	2018-04-04 12:44:02 -07:00
timerfd.c	Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL	2018-06-28 10:40:47 -07:00
userfaultfd.c	userfaultfd: hugetlbfs: fix userfaultfd_huge_must_wait() pte access	2018-07-03 17:32:18 -07:00
utimes.c	fs: add do_compat_futimesat() helper; remove in-kernel call to compat syscall	2018-04-02 20:15:44 +02:00
xattr.c	vfs: delete unnecessary assignment in vfs_listxattr	2018-05-29 13:22:41 -04:00