Richard Fitzgerald dfd2ffb373 ASoC: cs35l56: Prevent overwriting firmware ASP config ... Only populate the ASP1 config registers in the regmap cache if the ASP DAI is used. This prevents regcache_sync() from overwriting these registers with their defaults when the firmware owns control of these registers. On a SoundWire system the ASP could be owned by the firmware to share reference audio with the firmware on other cs35l56. Or it can be used as a normal codec-codec interface owned by the driver. The driver must not overwrite the registers if the firmware has control of them. The original implementation for this in commit 07f7d6e7a1 ("ASoC: cs35l56: Fix for initializing ASP1 mixer registers") was to still provide defaults for these registers, assuming that if they were never reconfigured from defaults then regcache_sync() would not write them out because they are not dirty. Unfortunately regcache_sync() is not that smart. If the chip has not reset (so the driver has not called regcache_mark_dirty()) a regcache_sync() could write out registers that are not dirty. To avoid accidental overwriting of the ASP registers, they are removed from the table of defaults and instead are populated with defaults only if one of the ASP DAI configuration functions is called. So if the DAI has never been configured, the firmware is assumed to have ownership of these registers, and the regmap cache will not contain any entries for them. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Fixes: 07f7d6e7a1 ("ASoC: cs35l56: Fix for initializing ASP1 mixer registers") Link: https://msgid.link/r/20240408101803.43183-5-rf@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>		2024-04-08 14:10:01 +01:00
..
acpi	ACPI updates for 6.9-rc1	2024-03-13 11:54:05 -07:00
asm-generic	export.h: remove include/asm-generic/export.h	2024-03-28 11:04:20 +09:00
clocksource
crypto	This update includes the following changes:	2024-03-15 14:46:54 -07:00
drm	drm fixes for 6.9-rc1	2024-03-21 19:04:31 -07:00
dt-bindings	Char/Misc and other driver subsystem updates for 6.9-rc1	2024-03-21 13:21:31 -07:00
keys
kunit
kvm	KVM: arm64: Fix host-programmed guest events in nVHE	2024-03-26 01:51:44 -07:00
linux	regmap: Add regmap_read_bypassed()	2024-04-08 14:09:58 +01:00
math-emu
media	media updates for v6.9-rc1	2024-03-15 11:36:54 -07:00
memory
misc
net	net: mana: Fix Rx DMA datasize and skb_over_panic	2024-04-03 19:32:03 -07:00
pcmcia
ras
rdma
rv
scsi	scsi: sd: Fix TCG OPAL unlock on system resume	2024-03-25 15:46:12 -04:00
soc	Char/Misc and other driver subsystem updates for 6.9-rc1	2024-03-21 13:21:31 -07:00
sound	ASoC: cs35l56: Prevent overwriting firmware ASP config	2024-04-08 14:10:01 +01:00
target
trace	tracing: Just use strcmp() for testing __string() and __assign_str() match	2024-03-19 11:23:30 -07:00
uapi	SCSI fixes on 20240330	2024-03-30 13:44:52 -07:00
ufs
vdso	vdso: Use CONFIG_PAGE_SHIFT in vdso/datapage.h	2024-04-03 21:50:04 +02:00
video
xen